-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): add state mutability computation from world param #2049
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2049 +/- ##
==========================================
- Coverage 68.35% 68.32% -0.03%
==========================================
Files 323 326 +3
Lines 40450 40426 -24
==========================================
- Hits 27648 27620 -28
- Misses 12802 12806 +4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
few doc related suggestions, aside from that LGTM!
Description
On the last update, where
self
andContractState
were removed from the#[dojo::interface]
, we lost the ability of generating an ABI with the correct state mutability of the systems, everything was aview
.However, for client side code generation from ABI, we do want the systems to be identified as
external
in the ABI.Also, now the use of
self
is definitely removed fromdojo::interface
anddojo::contract
. Only theworld
parameter must be used.ref world: IWorldDispatcher
orworld: @IWorldDispatcher
.view
.Related issue
Closes #1995.
Tests
Added to documentation?
Checklist
scripts/prettier.sh
,scripts/rust_fmt.sh
,scripts/cairo_fmt.sh
)scripts/clippy.sh
,scripts/docs.sh
)