test(katana-rpc): don't use binary runner in katana tests

[kariy]

Summary by CodeRabbit

• New Features

  • Enhanced test configuration with structured MessagingConfig and SequencingConfig objects for improved clarity and type safety.

• Bug Fixes

  • Streamlined transaction handling logic by replacing the previous runner-based approach with a sequencer-based method.

• Refactor

  • Updated test setup to utilize get_default_test_config for creating configuration objects, improving maintainability.

[coderabbitai]

Walkthrough

Ohayo, sensei! The pull request introduces changes primarily in the Cargo.toml file of the katana-rpc package by removing the katana-runner.workspace = true line from the development dependencies. Additionally, the messaging.rs test file has been significantly updated to utilize new structured configuration objects, namely MessagingConfig and SequencingConfig, replacing the previous JSON-based setup. This enhances type safety and clarity in the test code while transitioning from a runner-based approach to a sequencer-based one.

Changes

File	Change Summary
crates/katana/rpc/rpc/Cargo.toml	Removed katana-runner.workspace = true from [dev-dependencies].
crates/katana/rpc/rpc/tests/messaging.rs	Added imports for MessagingConfig and SequencingConfig, replaced JSON config with structured objects, streamlined sequencer initialization, and updated transaction handling logic. New structs MessagingConfig and SequencingConfig introduced.

Possibly related PRs

• Improve Katana runner macro #2464: The changes in the Cargo.toml file for the katana-rpc package relate to the removal of the katana-runner.workspace = true line, similar to modifications in the Cargo.toml of the katana/runner project.
• chore(katana): de-featurize base messaging #2506: Modifications to the Cargo.toml file in the main PR regarding the katana-node dependency align with changes in the Cargo.toml for the katana package, suggesting a broader restructuring of dependencies.

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 9b47e7c and 4c45e13.

⛔ Files ignored due to path filters (1)

• Cargo.lock is excluded by !**/*.lock

📒 Files selected for processing (2)

• crates/katana/rpc/rpc/Cargo.toml (0 hunks)
• crates/katana/rpc/rpc/tests/messaging.rs (3 hunks)

💤 Files with no reviewable changes (1)

• crates/katana/rpc/rpc/Cargo.toml

🧰 Additional context used

🔇 Additional comments (2)

crates/katana/rpc/rpc/tests/messaging.rs (2)

75-77: Ohayo, sensei! Verify that the default SequencingConfig meets test requirements

The SequencingConfig is initialized with default values using SequencingConfig::default(). Please confirm that the default configuration aligns with the intended test setup and that all necessary parameters are appropriately configured.

---

65-73: ⚠️ Potential issue

Ohayo, sensei! Ensure proper handling of the private_key in MessagingConfig

The private_key field in MessagingConfig is currently set to an empty string. If the private key is required for authentication or signing messages, leaving it empty may lead to runtime errors or unintended behavior. Please verify whether the private_key is necessary and ensure it is securely provided.

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.34%. Comparing base (9b47e7c) to head (4c45e13).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2525      +/-   ##
==========================================
+ Coverage   68.56%   69.34%   +0.78%     
==========================================
  Files         387      387              
  Lines       49988    49988              
==========================================
+ Hits        34273    34664     +391     
+ Misses      15715    15324     -391     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.