Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clean up unused deps #2532

Merged
merged 2 commits into from
Oct 13, 2024
Merged

chore: clean up unused deps #2532

merged 2 commits into from
Oct 13, 2024

Conversation

kariy
Copy link
Member

@kariy kariy commented Oct 13, 2024

resolve #2531

Summary by CodeRabbit

  • New Features
    • Introduced warnings for unused crate dependencies to enhance code quality.
  • Chores
    • Removed unnecessary dependencies from the saya and torii-graphql packages.
    • Reinstated essential dependencies in the torii-graphql package.

Copy link

coderabbitai bot commented Oct 13, 2024

Walkthrough

Ohayo, sensei! This pull request focuses on modifying the dependency management across several Cargo.toml files for the saya and torii-graphql packages. Key changes include the removal of specific dependencies and the addition of others, aiming to streamline the project. Additionally, new lint attributes have been introduced in the main.rs and lib.rs files to warn about unused crate dependencies, enhancing code quality without altering core functionalities.

Changes

File Change Summary
bin/saya/Cargo.toml Removed dependencies: clap-verbosity-flag, clap_complete, katana-primitives, katana-rpc-api.
bin/saya/src/main.rs Added warning attribute #![warn(unused_crate_dependencies)].
crates/torii/graphql/Cargo.toml Removed async-trait, added tokio, removed sozo-ops, reinstated starknet-crypto in dev-dependencies.
crates/torii/graphql/src/lib.rs Added warning attribute #![warn(unused_crate_dependencies)].

Assessment against linked issues

Objective Addressed Explanation
Resolve cargo-udeps failure (Issue #2531)

Possibly related PRs

Suggested reviewers

  • glihm

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 4e31429 and c8b63b7.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • crates/torii/graphql/Cargo.toml (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • crates/torii/graphql/Cargo.toml

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Oct 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.34%. Comparing base (77042b1) to head (c8b63b7).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2532      +/-   ##
==========================================
+ Coverage   69.32%   69.34%   +0.01%     
==========================================
  Files         388      388              
  Lines       49988    49988              
==========================================
+ Hits        34654    34664      +10     
+ Misses      15334    15324      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kariy kariy merged commit ac0fa99 into main Oct 13, 2024
15 checks passed
@kariy kariy deleted the unsed-deps branch October 13, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci: Github Action for cargo-udeps failed
1 participant