Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dojo 1.0.0-rc.0 #2595

Merged
merged 99 commits into from
Oct 30, 2024
Merged

dojo 1.0.0-rc.0 #2595

Show file tree
Hide file tree
Changes from 88 commits
Commits
Show all changes
99 commits
Select commit Hold shift + click to select a range
ded4d49
chore: add new dojo folder into crates
glihm Oct 21, 2024
d279db0
wip
glihm Oct 23, 2024
78f3d27
fix: wip tests
glihm Oct 23, 2024
a4224ae
fix: rename simple example
glihm Oct 23, 2024
2b8fce8
fix: rework abigen
glihm Oct 23, 2024
0f3767e
fmt
glihm Oct 23, 2024
1104ff1
wip
glihm Oct 23, 2024
637d77a
wip
glihm Oct 23, 2024
090da04
fix: rework remote world fetching
glihm Oct 23, 2024
6b10b34
fix: ensure namespaces are mapped correctly
glihm Oct 23, 2024
7023151
feat: add namespaces as resource too for the diff
glihm Oct 24, 2024
fd52b8d
feat: complete the diff computation
glihm Oct 24, 2024
23dea23
fix: fmt
glihm Oct 24, 2024
25dd91b
feat: add declarer and migration flow again
glihm Oct 24, 2024
07eba52
wip
glihm Oct 24, 2024
ef2dd56
fix: fix migration flow
glihm Oct 24, 2024
bf6bfb3
fix: adjust controller account and migrate
glihm Oct 25, 2024
3e20534
wip
glihm Oct 25, 2024
ed52937
wip: migration
glihm Oct 25, 2024
e3f4c31
fix
glihm Oct 25, 2024
bcaf1bd
fix
glihm Oct 25, 2024
ff8276f
fix: rework txs + error message on tx failed
glihm Oct 25, 2024
91f9190
fmt
glihm Oct 25, 2024
eea2394
fix: use disable_multicall
glihm Oct 25, 2024
df1b6c2
fix: add inspect command for world
glihm Oct 25, 2024
041825b
fix: add perms names and tag
glihm Oct 25, 2024
9972ead
fix: simplify resource management
glihm Oct 25, 2024
756ffa1
fix wip
glihm Oct 26, 2024
eccbed1
add comment to not forget cleaning on build
glihm Oct 26, 2024
2c0eaaa
fix: add clean back
glihm Oct 26, 2024
8e8cd61
clean
glihm Oct 26, 2024
dbb5bcd
fix: migration output clean and simple
glihm Oct 26, 2024
2691c26
fix: world upgrade
glihm Oct 26, 2024
07a8696
fix: test
glihm Oct 26, 2024
6569e5c
fix: ensure warning if world address/seed differ
glihm Oct 26, 2024
54cdb72
fix: refacto
glihm Oct 26, 2024
33ce776
fix: big refactor
glihm Oct 27, 2024
007cbf7
fix: ensure model and modelvalue are in the ABI
glihm Oct 27, 2024
14c3693
fix: add manifests back
glihm Oct 27, 2024
c05584c
fix: compiling workspace ok
glihm Oct 27, 2024
f0ca0d2
fix: simplify storage trait
glihm Oct 27, 2024
43310af
fix: add call again
glihm Oct 27, 2024
2f0e51e
wip: cairo test
glihm Oct 27, 2024
8c0ee9e
wip: tests
glihm Oct 27, 2024
93bb8b3
fix: fix upgrade with dojo_name now
glihm Oct 28, 2024
c39299c
fix: fix core tests
glihm Oct 28, 2024
90aa25a
merge main
glihm Oct 28, 2024
cdd6bc1
fix: order init contract
glihm Oct 28, 2024
3bf1276
chore: use scarb from dojo fork
glihm Oct 28, 2024
41421ed
fix: use cainome from remote branch
glihm Oct 28, 2024
ebebe59
feat: add multi-declarers
glihm Oct 28, 2024
0013815
fix: fix missing generate task migration
glihm Oct 28, 2024
f314357
chore: use fix rev for scarb
glihm Oct 28, 2024
3964db4
fix: regenerate world ABI
glihm Oct 28, 2024
dce7911
fix: regenerate world ABI
glihm Oct 28, 2024
8e11dbe
fix: use new cainome rev for event selector
glihm Oct 28, 2024
fd22343
feat: adjust torii for new events structure
glihm Oct 29, 2024
5a6afe3
fix: fmt
glihm Oct 29, 2024
9eab09b
chore: bump scarb
glihm Oct 29, 2024
bc48547
feat(torii): add support for new events historical
glihm Oct 29, 2024
d3df386
fix: migrate spawn and move
glihm Oct 29, 2024
c5dd9ee
fix: tests
glihm Oct 29, 2024
7f98e75
fix: fmt
glihm Oct 29, 2024
cd6ec0d
fix: cleanup
glihm Oct 30, 2024
958a3bc
fix: cairo test compilation
glihm Oct 30, 2024
b75c46e
fix: rename generated contracts for models and events for easier testing
glihm Oct 30, 2024
74a4071
chore: bump scarb
glihm Oct 30, 2024
34b6f1f
merge main
glihm Oct 30, 2024
1f9aca1
fix: complete workspace tests + clippy
glihm Oct 30, 2024
ad68e96
add metadata feature on dojo-world
notV4l Oct 30, 2024
beafc76
fix: fix CI path and scarb version + abigen check
glihm Oct 30, 2024
e951660
Merge remote-tracking branch 'dojo/feat/dojo-1-rc0' into feat/dojo-1-rc0
glihm Oct 30, 2024
a337950
fix: replace WorldMetadata to avoid using metadata feature
glihm Oct 30, 2024
7c8005b
fix: format check and tests
glihm Oct 30, 2024
d8e4e8a
fix: remove namespace bytearray from WorldStorage
glihm Oct 30, 2024
dce5174
fix: change namespaces to snapshot
glihm Oct 30, 2024
ba39a5a
fix: update db
glihm Oct 30, 2024
a1bd2d0
fix: world storage API update
glihm Oct 30, 2024
7871e95
fix: tests
glihm Oct 30, 2024
70c8de8
ci: remove bindgen check due to formatting
glihm Oct 30, 2024
479b698
fix: add bindgen back with new world representation
glihm Oct 30, 2024
33f4efc
chore: bump scarb
glihm Oct 30, 2024
077a252
fix: ensure namespaces are correctly mapped for default, and add traces
glihm Oct 30, 2024
0f3dbb1
fix: ensure multi declaration works + added timeout
glihm Oct 30, 2024
6968a19
fix: add back the world abi in the final manifest
glihm Oct 30, 2024
059b69e
feat: historical event messages
Larkooo Oct 30, 2024
0fab9fe
fix: ensure we have 2 outputs based on changes
glihm Oct 30, 2024
5d7f632
Merge remote-tracking branch 'dojo/feat/dojo-1-rc0' into feat/dojo-1-rc0
glihm Oct 30, 2024
fddeade
fix: display inspect
glihm Oct 30, 2024
86ec272
fix: ensure the tag is correctly output in the manifest
glihm Oct 30, 2024
ec39d39
torii clietn evnet messages
Larkooo Oct 30, 2024
df83f2e
Merge remote-tracking branch 'dojo/main' into feat/dojo-1-rc0
glihm Oct 30, 2024
5075baf
fix: merge main + update tests
glihm Oct 30, 2024
a132b26
spookyfy
notV4l Oct 30, 2024
58eed4e
feat: add sozo hash back
glihm Oct 30, 2024
ebd619c
Merge remote-tracking branch 'dojo/feat/dojo-1-rc0' into feat/dojo-1-rc0
glihm Oct 30, 2024
3fb7389
fix: fix fmt
glihm Oct 30, 2024
04e5c1c
fix: add sozo init back
glihm Oct 30, 2024
b87fbef
fix: fmt
glihm Oct 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
19 changes: 6 additions & 13 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,10 +112,12 @@ jobs:
- uses: actions/checkout@v3
- uses: software-mansion/setup-scarb@v1
with:
scarb-version: "2.7.0"
scarb-version: "2.8.4"
- run: |
scarb --manifest-path examples/spawn-and-move/Scarb.toml fmt --check
scarb --manifest-path crates/dojo-core/Scarb.toml fmt --check
scarb --manifest-path examples/simple/Scarb.toml fmt --check
scarb --manifest-path crates/dojo/core/Scarb.toml fmt --check
scarb --manifest-path crates/dojo/core-cairo-test/Scarb.toml fmt --check
Comment on lines +118 to +120
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Several Cairo projects are missing format checks

Ohayo sensei! The verification revealed multiple Cairo projects that aren't covered by the formatting checks. Here are the missing projects:

  • crates/dojo/lang/Scarb.toml
  • crates/benches/contracts/Scarb.toml
  • crates/katana/contracts/Scarb.toml
  • crates/katana/contracts/account/Scarb.toml
  • crates/katana/contracts/messaging/cairo/Scarb.toml
  • crates/torii/types-test/Scarb.toml
  • examples/game-lib/Scarb.toml
  • examples/game-lib/armory/Scarb.toml
  • examples/game-lib/bestiary/Scarb.toml

Note: The bin/sozo/tests/test_data/invalid_cairo_version/Scarb.toml can be excluded as it's a test fixture.

🔗 Analysis chain

Verify all Cairo projects are covered by fmt checks.

The manifest paths have been updated to reflect the new project structure. However, let's ensure we haven't missed any Cairo projects that should be checked for formatting.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Find all Scarb.toml files in the repository
echo "Searching for Scarb.toml files..."
fd --type f "Scarb.toml$" | while read -r manifest; do
    # Check if this manifest is included in the fmt checks
    if ! grep -q "scarb --manifest-path $manifest fmt" .github/workflows/ci.yml; then
        echo "Warning: $manifest not included in fmt checks"
    fi
done

Length of output: 3377


dojo-core-test:
needs: build
Expand All @@ -130,7 +132,7 @@ jobs:
- uses: actions/checkout@v3
- run: |
chmod +x /tmp/bins/sozo
/tmp/bins/sozo --manifest-path crates/dojo-core/Scarb.toml test
/tmp/bins/sozo --manifest-path crates/dojo/core/Scarb.toml test

dojo-spawn-and-move-example-test:
needs: build
Expand All @@ -147,15 +149,6 @@ jobs:
chmod +x /tmp/bins/sozo
/tmp/bins/sozo --manifest-path examples/spawn-and-move/Scarb.toml test

dojo-world-bindings-check:
runs-on: ubuntu-latest
container:
image: ghcr.io/dojoengine/dojo-dev:v1.0.0-alpha.17
steps:
- uses: actions/checkout@v3
- uses: Swatinem/rust-cache@v2
- run: cargo run --bin dojo-world-abigen -- --check

clippy:
runs-on: ubuntu-latest-4-cores
container:
Expand Down Expand Up @@ -201,5 +194,5 @@ jobs:
nohup /tmp/bins/katana --accounts 2 --disable-fee &
- run: |
/tmp/bins/sozo --manifest-path examples/spawn-and-move/Scarb.toml build
/tmp/bins/sozo --manifest-path examples/spawn-and-move/Scarb.toml migrate apply
/tmp/bins/sozo --manifest-path examples/spawn-and-move/Scarb.toml migrate
- run: hurl --test examples/rpc/**/*.hurl
2 changes: 1 addition & 1 deletion .tool-versions
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
scarb 2.7.0
scarb 2.8.4
starknet-foundry 0.30.0
Loading
Loading