-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update devcontainer image: v1.0.0-rc.1 #2616
Conversation
WalkthroughOhayo, sensei! This pull request primarily updates the Docker image version across various configuration files related to the Rust development environment. The image version has been incremented from Changes
Possibly related PRs
Suggested reviewers
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (4)
✅ Files skipped from review due to trivial changes (3)
🔇 Additional comments (3).github/workflows/ci.yml (3)Line range hint The ensure-docker job now properly verifies that the Katana process starts and runs without errors. This is a good addition to catch potential runtime issues early. 🧰 Tools🪛 actionlint32-32: label "ubuntu-latest-32-cores" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-14.0", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-13.0", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "macos-12.0", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file (runner-label)
The Docker image version has been consistently updated from #!/bin/bash
# Verify all Docker image references are using the same version
rg "ghcr.io/dojoengine/dojo-dev:" | grep -v "v1.0.0-rc.1" && {
echo "Found inconsistent Docker image versions"
exit 1
} Also applies to: 126-128, 141-143, 155-157, 164-166, 173-175 Line range hint The test job now includes new commands to extract database files, but we should verify these files exist in the repository. ✅ Verification successfulOhayo! The tar.gz files are present and properly referenced, sensei! The verification shows that both
🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Check if the required tar.gz files exist in the repository
for file in spawn-and-move-db.tar.gz types-test-db.tar.gz; do
if ! fd -t f "^${file}$"; then
echo "Warning: ${file} not found in repository"
fi
done
Length of output: 149 Script: #!/bin/bash
# Let's try a different approach to find these files
# First, let's check for any .tar.gz files in the repository
echo "=== Searching for tar.gz files ==="
fd -e tar.gz
# Let's also check if these files might be generated or mentioned in any build scripts
echo -e "\n=== Checking for references to these files in scripts ==="
rg -l "spawn-and-move-db\.tar\.gz|types-test-db\.tar\.gz"
# Let's also check the workflow file itself to see the context
echo -e "\n=== Checking workflow file context ==="
if [ -f ".github/workflows/ci.yml" ]; then
echo "Content around tar extraction in ci.yml:"
rg -A 5 -B 5 "tar -xzf" .github/workflows/ci.yml
fi
Length of output: 1210 🧰 Tools🪛 actionlint32-32: label "ubuntu-latest-32-cores" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-14.0", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-13.0", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "macos-12.0", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file (runner-label) Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2616 +/- ##
==========================================
- Coverage 57.93% 57.93% -0.01%
==========================================
Files 393 393
Lines 48567 48567
==========================================
- Hits 28139 28138 -1
- Misses 20428 20429 +1 ☔ View full report in Codecov by Sentry. |
Automated changes by create-pull-request GitHub action
Summary by CodeRabbit
New Features
v1.0.0-rc.1
across various workflows, enhancing the development environment.Bug Fixes
Chores