Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update devcontainer image: v1.0.0-rc.1 #2616

Merged
merged 1 commit into from
Nov 3, 2024
Merged

Update devcontainer image: v1.0.0-rc.1 #2616

merged 1 commit into from
Nov 3, 2024

Conversation

tarrencev
Copy link
Contributor

@tarrencev tarrencev commented Nov 3, 2024

Automated changes by create-pull-request GitHub action

Summary by CodeRabbit

  • New Features

    • Updated Docker image version to v1.0.0-rc.1 across various workflows, enhancing the development environment.
  • Bug Fixes

    • Improved CI workflow with additional commands for better test preparation and process checks.
  • Chores

    • Minor updates to workflow configurations for benchmarking and release processes to ensure consistency and reliability.

Copy link

coderabbitai bot commented Nov 3, 2024

Walkthrough

Ohayo, sensei! This pull request primarily updates the Docker image version across various configuration files related to the Rust development environment. The image version has been incremented from v1.0.0-rc.0 to v1.0.0-rc.1 in the .devcontainer/devcontainer.json, CI workflows, benchmarking workflows, and the release dispatch workflow. Additionally, some CI jobs have been enhanced with new commands for extracting files necessary for testing. No other significant changes to configuration settings or job structures are present.

Changes

File Change Summary
.devcontainer/devcontainer.json Updated Docker image version from v1.0.0-rc.0 to v1.0.0-rc.1.
.github/workflows/bench.yml Updated Docker image version from v1.0.0-rc.0 to v1.0.0-rc.1 for jobs bench-katana and bench-sozo.
.github/workflows/ci.yml Updated Docker image version from v1.0.0-rc.0 to v1.0.0-rc.1 in jobs: test, ensure-wasm, dojo-core-test, dojo-spawn-and-move-example-test, clippy, fmt, and docs. Added commands to extract files in the test job and added a check for the katana process in the ensure-docker job.
.github/workflows/release-dispatch.yml Updated Docker image version from v1.0.0-rc.0 to v1.0.0-rc.1 in the propose-release job.

Possibly related PRs

Suggested reviewers

  • glihm

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between c789997 and 1474bff.

📒 Files selected for processing (4)
  • .devcontainer/devcontainer.json (1 hunks)
  • .github/workflows/bench.yml (2 hunks)
  • .github/workflows/ci.yml (7 hunks)
  • .github/workflows/release-dispatch.yml (1 hunks)
✅ Files skipped from review due to trivial changes (3)
  • .devcontainer/devcontainer.json
  • .github/workflows/bench.yml
  • .github/workflows/release-dispatch.yml
🔇 Additional comments (3)
.github/workflows/ci.yml (3)

Line range hint 89-103: Ohayo! Robust Katana process verification added.

The ensure-docker job now properly verifies that the Katana process starts and runs without errors. This is a good addition to catch potential runtime issues early.

🧰 Tools
🪛 actionlint

32-32: label "ubuntu-latest-32-cores" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-14.0", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-13.0", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "macos-12.0", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file

(runner-label)


59-61: Ohayo sensei! Docker image version updates look consistent.

The Docker image version has been consistently updated from v1.0.0-rc.0 to v1.0.0-rc.1 across all jobs. This maintains environment consistency throughout the CI pipeline.

#!/bin/bash
# Verify all Docker image references are using the same version
rg "ghcr.io/dojoengine/dojo-dev:" | grep -v "v1.0.0-rc.1" && {
    echo "Found inconsistent Docker image versions"
    exit 1
}

Also applies to: 126-128, 141-143, 155-157, 164-166, 173-175


Line range hint 34-52: Ohayo! Verify the tar extraction commands.

The test job now includes new commands to extract database files, but we should verify these files exist in the repository.

✅ Verification successful

Ohayo! The tar.gz files are present and properly referenced, sensei!

The verification shows that both spawn-and-move-db.tar.gz and types-test-db.tar.gz files:

  • Exist in the repository root
  • Are referenced in build scripts (scripts/rebuild_test_artifacts.sh and xtask/generate-test-db/src/main.rs)
  • Are correctly used in the CI workflow for test database setup
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Check if the required tar.gz files exist in the repository
for file in spawn-and-move-db.tar.gz types-test-db.tar.gz; do
    if ! fd -t f "^${file}$"; then
        echo "Warning: ${file} not found in repository"
    fi
done

Length of output: 149


Script:

#!/bin/bash
# Let's try a different approach to find these files
# First, let's check for any .tar.gz files in the repository
echo "=== Searching for tar.gz files ==="
fd -e tar.gz

# Let's also check if these files might be generated or mentioned in any build scripts
echo -e "\n=== Checking for references to these files in scripts ==="
rg -l "spawn-and-move-db\.tar\.gz|types-test-db\.tar\.gz"

# Let's also check the workflow file itself to see the context
echo -e "\n=== Checking workflow file context ==="
if [ -f ".github/workflows/ci.yml" ]; then
    echo "Content around tar extraction in ci.yml:"
    rg -A 5 -B 5 "tar -xzf" .github/workflows/ci.yml
fi

Length of output: 1210

🧰 Tools
🪛 actionlint

32-32: label "ubuntu-latest-32-cores" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-14.0", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-13.0", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "macos-12.0", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file

(runner-label)


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Nov 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.93%. Comparing base (c789997) to head (1474bff).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2616      +/-   ##
==========================================
- Coverage   57.93%   57.93%   -0.01%     
==========================================
  Files         393      393              
  Lines       48567    48567              
==========================================
- Hits        28139    28138       -1     
- Misses      20428    20429       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants