Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat; use graphiql & upgrade version #2683

Merged
merged 3 commits into from
Nov 13, 2024
Merged

Conversation

Larkooo
Copy link
Collaborator

@Larkooo Larkooo commented Nov 13, 2024

Summary by CodeRabbit

  • New Features

    • Updated the web interface for GraphQL from Playground to GraphiQL, enhancing user experience.
  • Bug Fixes

    • Improved dependency management by upgrading async-graphql and async-graphql-warp to the latest versions for better stability and performance.

Copy link

coderabbitai bot commented Nov 13, 2024

Walkthrough

Ohayo, sensei! The changes in this pull request involve updates to the Cargo.toml file for the torii-graphql package, where the dependency versions for async-graphql and async-graphql-warp have been upgraded from 6.0.7 to 7.0.11. Additionally, the implementation of the GraphQL server in server.rs has been modified, replacing the GraphQL Playground with the GraphiQL interface, including updates to the import statements and the endpoint configurations.

Changes

File Path Change Summary
crates/torii/graphql/Cargo.toml Updated dependency versions: async-graphql and async-graphql-warp from 6.0.7 to 7.0.11.
crates/torii/graphql/src/server.rs Replaced GraphQL Playground with GraphiQL; removed GraphQLPlaygroundConfig, added GraphiQLSource, updated endpoint configurations.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant Server
    Client->>Server: Request GraphiQL Interface
    Server->>Client: Serve GraphiQL Interface
    Client->>Server: Send GraphQL Query
    Server->>Client: Return GraphQL Response
Loading

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 6f8c2b5 and 01dee92.

📒 Files selected for processing (1)
  • crates/torii/graphql/src/server.rs (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • crates/torii/graphql/src/server.rs

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Larkooo Larkooo enabled auto-merge (squash) November 13, 2024 04:55
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 57.57%. Comparing base (c16f3c9) to head (01dee92).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
crates/torii/graphql/src/server.rs 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2683      +/-   ##
==========================================
- Coverage   57.57%   57.57%   -0.01%     
==========================================
  Files         404      404              
  Lines       51139    51140       +1     
==========================================
  Hits        29443    29443              
- Misses      21696    21697       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Larkooo Larkooo merged commit 5826bd0 into dojoengine:main Nov 13, 2024
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants