Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 Use the properties system instead of the service root #206

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

Schlepptop
Copy link

No description provided.

@josegonzalez
Copy link
Member

General comment: we'll need to handle migration of the existing variables to the new properties system.

@Schlepptop
Copy link
Author

Schlepptop commented Jul 16, 2020

Would that be fitting to do in the install file?
Or isn't that used during updates?

@josegonzalez
Copy link
Member

Maybe update - can you check what trigger we use in the plugin:update calls? - though we might need to do both - I think plugin:install is more or less plugin:update...

@Schlepptop
Copy link
Author

They can be different, plugn calls the install hooks for install and update for update, but with update just being a link to install in this plugin, they really are the same.

@Schlepptop Schlepptop marked this pull request as ready for review July 17, 2020 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants