Fix postgres:create when running inside a docker container #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…HOST_ROOT when creating the ssl certs Since the script create_ssl_certs.sh is executed from inside the container, the directory is not the host one, but the container one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #299
When running the command
dokku postgres:create [some_name]from dokku installed inside docker, the command failed (silently), since it points to the host directory instead of the one inside the container.I've switched from
SERVICE_HOST_ROOTtoSERVICE_ROOTwhen runningcreate_ssl_certs.shI've also put a
set -ein the creation scripts to improve debugging.