Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure linked services are running before build #138

Open
CQCumbers opened this issue Sep 14, 2019 · 1 comment
Open

Ensure linked services are running before build #138

CQCumbers opened this issue Sep 14, 2019 · 1 comment
Labels
type: enhancement type: service

Comments

@CQCumbers
Copy link

I was instructed to file an issue here on the dokku slack channel.

If the services linked to a dokku app are not running, building the app will fail with an error of the form Unable to find image 'dokku/myapp:latest' locally. This is because when Docker attempts to run a container, if linked containers are not available, Docker will say that the image is missing, when in fact the linked containers are missing. Manually restarting linked containers will fix the problem, but it could be prevented by a trigger in the datastore plugins that automatically ensures linked services are running before doing a build.
@josegonzalez josegonzalez mentioned this issue Sep 13, 2021
Closed
This was referenced Sep 13, 2021
Closed
Closed
josegonzalez added a commit to dokku/dokku-clickhouse that referenced this issue Sep 13, 2021
@josegonzalez
fix: start linked datastores when an app is started or restored
27c931b 
This won't _also_ fix issues when an app is deployed as there isn't an exposed hook for it, but it should fix many other issues.

For the app deployment problem, we'll need a new hook upstream.

Refs dokku/dokku-redis#138
josegonzalez added a commit to dokku/dokku-couchdb that referenced this issue Sep 13, 2021
@josegonzalez
fix: start linked datastores when an app is started or restored
45d9280 
This won't _also_ fix issues when an app is deployed as there isn't an exposed hook for it, but it should fix many other issues.

For the app deployment problem, we'll need a new hook upstream.

Refs dokku/dokku-redis#138
josegonzalez added a commit to dokku/dokku-elasticsearch that referenced this issue Sep 13, 2021
@josegonzalez
fix: start linked datastores when an app is started or restored
f6f137b 
This won't _also_ fix issues when an app is deployed as there isn't an exposed hook for it, but it should fix many other issues.

For the app deployment problem, we'll need a new hook upstream.

Refs dokku/dokku-redis#138
josegonzalez added a commit to dokku/dokku-graphite that referenced this issue Sep 13, 2021
@josegonzalez
fix: start linked datastores when an app is started or restored
42240c0 
This won't _also_ fix issues when an app is deployed as there isn't an exposed hook for it, but it should fix many other issues.

For the app deployment problem, we'll need a new hook upstream.

Refs dokku/dokku-redis#138
josegonzalez added a commit to dokku/dokku-mariadb that referenced this issue Sep 13, 2021
@josegonzalez
fix: start linked datastores when an app is started or restored
d7e022a 
This won't _also_ fix issues when an app is deployed as there isn't an exposed hook for it, but it should fix many other issues.

For the app deployment problem, we'll need a new hook upstream.

Refs dokku/dokku-redis#138
josegonzalez added a commit to dokku/dokku-memcached that referenced this issue Sep 13, 2021
@josegonzalez
fix: start linked datastores when an app is started or restored
77d3f27 
This won't _also_ fix issues when an app is deployed as there isn't an exposed hook for it, but it should fix many other issues.

For the app deployment problem, we'll need a new hook upstream.

Refs dokku/dokku-redis#138
josegonzalez added a commit to dokku/dokku-mongo that referenced this issue Sep 13, 2021
@josegonzalez
fix: start linked datastores when an app is started or restored
323d859 
This won't _also_ fix issues when an app is deployed as there isn't an exposed hook for it, but it should fix many other issues.

For the app deployment problem, we'll need a new hook upstream.

Refs dokku/dokku-redis#138
josegonzalez added a commit to dokku/dokku-mysql that referenced this issue Sep 13, 2021
@josegonzalez
fix: start linked datastores when an app is started or restored
bab79e8 
This won't _also_ fix issues when an app is deployed as there isn't an exposed hook for it, but it should fix many other issues.

For the app deployment problem, we'll need a new hook upstream.

Refs dokku/dokku-redis#138
josegonzalez added a commit to dokku/dokku-nats that referenced this issue Sep 13, 2021
@josegonzalez
fix: start linked datastores when an app is started or restored
df9f001 
This won't _also_ fix issues when an app is deployed as there isn't an exposed hook for it, but it should fix many other issues.

For the app deployment problem, we'll need a new hook upstream.

Refs dokku/dokku-redis#138
josegonzalez added a commit to dokku/dokku-omnisci that referenced this issue Sep 13, 2021
@josegonzalez
fix: start linked datastores when an app is started or restored
80b9e49 
This won't _also_ fix issues when an app is deployed as there isn't an exposed hook for it, but it should fix many other issues.

For the app deployment problem, we'll need a new hook upstream.

Refs dokku/dokku-redis#138
josegonzalez added a commit to dokku/dokku-postgres that referenced this issue Sep 13, 2021
@josegonzalez
fix: start linked datastores when an app is started or restored
f1d60d6 
This won't _also_ fix issues when an app is deployed as there isn't an exposed hook for it, but it should fix many other issues.

For the app deployment problem, we'll need a new hook upstream.

Refs dokku/dokku-redis#138
josegonzalez added a commit to dokku/dokku-pushpin that referenced this issue Sep 13, 2021
@josegonzalez
fix: start linked datastores when an app is started or restored
f1d1378 
This won't _also_ fix issues when an app is deployed as there isn't an exposed hook for it, but it should fix many other issues.

For the app deployment problem, we'll need a new hook upstream.

Refs dokku/dokku-redis#138
josegonzalez added a commit to dokku/dokku-rabbitmq that referenced this issue Sep 13, 2021
@josegonzalez
fix: start linked datastores when an app is started or restored
15b9b53 
This won't _also_ fix issues when an app is deployed as there isn't an exposed hook for it, but it should fix many other issues.

For the app deployment problem, we'll need a new hook upstream.

Refs dokku/dokku-redis#138
josegonzalez added a commit that referenced this issue Sep 13, 2021
@josegonzalez
fix: start linked datastores when an app is started or restored
258eb2f 
This won't _also_ fix issues when an app is deployed as there isn't an exposed hook for it, but it should fix many other issues.

For the app deployment problem, we'll need a new hook upstream.

Refs #138
josegonzalez added a commit to dokku/dokku-rethinkdb that referenced this issue Sep 13, 2021
@josegonzalez
fix: start linked datastores when an app is started or restored
d2c6362 
This won't _also_ fix issues when an app is deployed as there isn't an exposed hook for it, but it should fix many other issues.

For the app deployment problem, we'll need a new hook upstream.

Refs dokku/dokku-redis#138
josegonzalez added a commit to dokku/dokku-solr that referenced this issue Sep 13, 2021
@josegonzalez
fix: start linked datastores when an app is started or restored
0a2082a 
This won't _also_ fix issues when an app is deployed as there isn't an exposed hook for it, but it should fix many other issues.

For the app deployment problem, we'll need a new hook upstream.

Refs dokku/dokku-redis#138
@josegonzalez
Copy link
Member

We'll need a new hook - maybe builder-build-pre $BUILDER_TYPE $APP ? - that we can use to start linked services prior to deploy. There isn't a global one, so if we did this hook by hook (pre-build-dockerfile, pre-build-herokuish, pre-build-pack) then we wouldn't support newer build methods as time goes on. Additionally, adding a new hook each time would be annoying.

That said, this should help with many cases, except for if a datastore crashes and a user deploys afterwards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: enhancement type: service
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@josegonzalez @CQCumbers