Skip to content

range error correction #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

range error correction #26

wants to merge 1 commit into from

Conversation

Riczap
Copy link

@Riczap Riczap commented Mar 5, 2023

Updated the cpp code for the detection function since some users where having issues with the for loop going out of range.

Updated the cpp code for the detection function since some users where having issues with the for loop going out of range.
@IkrameBeggar
Copy link

Hello, I updated the for loop but still getting the same error. Vector subscript out of range

@Riczap
Copy link
Author

Riczap commented May 18, 2023

Hello, I updated the for loop but still getting the same error. Vector subscript out of range

Hi! Did you try downloading the changed file just in case you missed something? If that doesn't work I'll se what I can do.

@IkrameBeggar
Copy link

Hello, I just modified the part you mentioned

@IkrameBeggar
Copy link

I just downloaded your file but still getting the same error 😓

@doleron
Copy link
Owner

doleron commented May 18, 2023

Hi, thank you for the PF!
Did you check if this code runs with OpenCV 4.5.4?

@IkrameBeggar
Copy link

I will check

@Riczap
Copy link
Author

Riczap commented May 18, 2023

I will check

I'll also verify that the code I uploaded is working well once I get home.
Can you post a screenshot with the specific error that you are getting?

@IkrameBeggar
Copy link

I will check

I'll also verify that the code I uploaded is working well once I get home. Can you post a screenshot with the specific error that you are getting?

It worked when I used opencv version 4.5.4
Thank you so much

@Riczap
Copy link
Author

Riczap commented May 18, 2023

I will check

I'll also verify that the code I uploaded is working well once I get home. Can you post a screenshot with the specific error that you are getting?

It worked when I used opencv version 4.5.4
Thank you so much

Good to know! No problem.

@IkrameBeggar
Copy link

I will check

I'll also verify that the code I uploaded is working well once I get home. Can you post a screenshot with the specific error that you are getting?

It worked when I used opencv version 4.5.4
Thank you so much

Good to know! No problem.

@Riczap Hello again, I am having a problem with the output and don't know what the issue is. Can you help with that?
Screenshot (46)

@Riczap
Copy link
Author

Riczap commented May 19, 2023

It looks like the model is properly detecting the objects but either the NMS (Non-Maximun Supression) part of the code (for loop section that was modified) isn't working well or the model is having problems.

I have a cpp file just to test if everything is working properly based on this repo it just loads an image and displays the results. Can you try downloading the files testing it? https://github.com/Riczap/YOLOv5-ObjectDetection-Cpp

@IkrameBeggar
Copy link

It looks like the model is properly detecting the objects but either the NMS (Non-Maximun Supression) part of the code (for loop section that was modified) isn't working well or the model is having problems.

I have a cpp file just to test if everything is working properly based on this repo it just loads an image and displays the results. Can you try downloading the files testing it? https://github.com/Riczap/YOLOv5-ObjectDetection-Cpp

Alright I will do that

@IkrameBeggar
Copy link

IkrameBeggar commented May 19, 2023

It looks like the model is properly detecting the objects but either the NMS (Non-Maximun Supression) part of the code (for loop section that was modified) isn't working well or the model is having problems.

I have a cpp file just to test if everything is working properly based on this repo it just loads an image and displays the results. Can you try downloading the files testing it? https://github.com/Riczap/YOLOv5-ObjectDetection-Cpp

image

It works, thank you so much

@Riczap
Copy link
Author

Riczap commented May 19, 2023

Good to know! You can use that as a template to use your model.

@IkrameBeggar
Copy link

Good to know! You can use that as a template to use your model.

I will, Thank you so much for your help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants