。 #2
Merged
。 #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsqadmin: display errors
nsqadmin: dedupe of producers from lookupd not working
nsqadmin: fix deferred message count
nsqadmin: fix regression when querying nsqd directly
nsqadmin: disambiguate nsqadmin notifications
nsqadmin: update header
nsqadmin: dynamic graphite timeframe
nsqd: expose memory stats under /stats
bash glob trick to match only folders nsqadmin moved to apps/ and is thus included in the glob already
test more go versions on Travis CI
quick hacky fix, instead of "proper" locking
nsqd: retry sub to ephemeral topic/channel which is Exiting
avoid coveralls service failure making travis tests fail
test: ignore failure to push to coveralls
nsqd, nsqlookupd, nsqadmin: replace verbose with log-level
minor fix for --log-level flag help text must set opts before logging errors in New() re-order log stuff in Options structs treat logLevel the same in nsqd, nsqlookupd, nsqadmin Fix tests: multiple nsqlookupds need their own Options structs, now that nsqlookupd has logLevel in its Options. Otherwise the race detector complains when one of the nsqlookupds writes the derived int logLevel while another reads it for logging.
introduce LogLevel type NilLogger for disabling logging consolidate LogLevel tests into internal/lg/ consolidate TestNoLogger
Instead of setting a Logger for github.com/nsqio/nsq/internal packages, pass a logf() function, so it is called with and honors a LogLevel. * internal/clusterinfo/ * internal/http_api/ * internal/protocol/ nsqd lookupPeer also needed to be converted Get rid of interal.app.Logger type, but internal/test/ needs its own Logger definition to avoid circular import with internal/lg/ tests.
*: internal logging package refactor
Instead segmentio_logo.png it should be segment_logo.png See: https://github.com/nsqio/nsqio.github.io/blob/master/static/img/segment_logo.png
Fix segment.com logo URL in README.md
fix vet error in clusterinfo/data.go
nsqd: fix nil pointer when memstats enabled
nsqadmin: X-Forwarded-User based ACL
nsqadmin: Update bindata for admin-user ACL changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
。