-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aggregate events streaming #160
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@jakhog Brought up a performance improvement that I@m gonna implement :) |
mhelleborg
reviewed
Sep 8, 2022
jakhog
suggested changes
Sep 13, 2022
...verters/for_AggregateEventToSDKConverter/given/committed_aggregate_events_and_a_converter.cs
Show resolved
Hide resolved
Specifications/Aggregates/for_AggregateRoot/given/committed_events_and_two_aggregate_roots.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Jakob Høgenes <1014990+jakhog@users.noreply.github.com>
…ET.SDK into aggregate-events-streaming
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new method to the
EventStore
for fetching committed aggregate events filtered by event types. This allows us to change the rehydration of aggregates to be much more effective by just fetching the committed aggregate events for an aggregate that are relevant to the rehydration (meaning that there are anOn
method for that event type). This can have a significant impact on the performance of aggregates that have many events, but few state changes or are completely stateless.Added
FetchForAggregate
that takes in a list event types used for filteringFetchStreamForAggregate
fetches a stream of committed aggregate event batchesChanged
AggregateRootVersion
on theCommittedAggregateEvents
now represents the current aggregate root version of the aggregate root, not the version of the last committed aggregate event>= 8.5.0
of the RuntimeFixed