Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aggregate request deduplication #220

Merged
merged 2 commits into from
Jun 8, 2023
Merged

Aggregate request deduplication #220

merged 2 commits into from
Jun 8, 2023

Conversation

mhelleborg
Copy link
Member

Summary

Removed retries against aggregate actors. Added new test classes for Aggregates.

Added

  • Additional helpers / assertions for testing aggregate roots

Fixed

  • Removed potential retries on Aggregate.Perform, which could occur when response times are greater than the set retry timeout.

@mhelleborg mhelleborg self-assigned this Jun 8, 2023
TomasEkeli
TomasEkeli approved these changes Jun 8, 2023
View reviewed changes
Copy link
Contributor

@TomasEkeli TomasEkeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

took a little while to understand the deduplication-thing: it's using proto middleware to make sure we don't actually send to two aggregates if the request is just a little slow

@mhelleborg mhelleborg merged commit 48bd63c into master Jun 8, 2023
@mhelleborg mhelleborg deleted the aggregate-deduplication branch June 8, 2023 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomasEkeli TomasEkeli TomasEkeli approved these changes

Assignees

@mhelleborg mhelleborg

Labels
patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mhelleborg @TomasEkeli