Release Codename 'Aragorn' #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add method for building with all event handlers
* Add sample for registering event handlers from app * Rude way of getting all referenced assemblies
The context establisher returns nothing when not releasing.
Release versions and nuget notes
Add release notes to NuGet packages
Does it work with single quotes maybe
Use msbuild output format
Register event types and aggregates
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
jakhog
reviewed
Nov 4, 2021
...e/Aggregates/Builders/ProvidedAggregateRootTypeDoesNotMatchAggregateRootTypeFromAttribute.cs
Outdated
Show resolved
Hide resolved
Small fixes
Moar fixes
| // Copyright (c) Dolittle. All rights reserved. | ||
| // Licensed under the MIT license. See LICENSE file in the project root for full license information. | ||
|
|
||
| using System; |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
| // Copyright (c) Dolittle. All rights reserved. | ||
| // Licensed under the MIT license. See LICENSE file in the project root for full license information. | ||
|
|
||
| using System; |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
| } | ||
| }; | ||
|
|
||
| async Task Register(EventTypeRegistrationRequest request, CancellationToken cancellationToken) |
There was a problem hiding this comment.
Method Register has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Fix bug and nice logs
| return request; | ||
| } | ||
|
|
||
| async Task Register(EventTypeRegistrationRequest request, CancellationToken cancellationToken) |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
| /// <param name="aggregateRootTypes">The aggregate root types to register.</param> | ||
| /// <param name="cancellationToken">The <see cref="CancellationToken"/>.</param> | ||
| /// <returns>A <see cref="Task"/> representing the asynchronous operation.</returns> | ||
| public Task Register(IEnumerable<AggregateRootType> aggregateRootTypes, CancellationToken cancellationToken) |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
| /// <param name="eventTypes">The event types to register.</param> | ||
| /// <param name="cancellationToken">The <see cref="CancellationToken"/>.</param> | ||
| /// <returns>A <see cref="Task"/> representing the asynchronous operation.</returns> | ||
| public Task Register(IEnumerable<EventType> eventTypes, CancellationToken cancellationToken) |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a problem with aggregates so that it now can be used in an async way. Registration of event types and aggregate roots to the Runtime.
Added
Changed
Fixed