Skip to content
This repository has been archived by the owner on Apr 20, 2019. It is now read-only.

[version] patch version bump (new ember rule) #37

Closed
wants to merge 1 commit into from

Conversation

yowainwright
Copy link
Contributor

What changed?

Are there gotchas?


Pull Request Todo
  • Solicit reviews from domain experts or others outside this PR's squad
Post-Deploy Todo

In the event an outage related to this PR occurs, rollback immediately, then debug: https://jenkins-deploy.aws.shave.io/job/Production/job/rollback/

Code Review Guidelines
  • Ensure readability and good organization
  • Ensure classes, functions, components, and variables are well-named
  • Ensure the diff is small
  • Ensure this PR does only one thing
  • Ensure the code is DRY (more than twice repeated)
  • Ensure tricky code is removed or explained with a comment
  • Ensure TODO comments and WHY comments are added where applicable

@@ -4,6 +4,7 @@ module.exports = {
extends: [
require.resolve('./'),
],
root: true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does this do?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't. It just ensures that an ember eslint config doesn't affect other repositories besides itself. It could be beneficial in the future but is not currently.

That is all.

@yowainwright yowainwright deleted the add-root-rule-ember branch January 3, 2019 18:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants