Boot: Fix handling of M3U file paths containing backslashes #11372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm confused about this fix (which might just mean it needs more documentation): why isn't this fixing SplitPath instead to do the right thing? |
|
(Or, alternatively, having the m3u code use UnifyPathSeparators or something similar to properly normalize everything to / instead of \) |
Previously, if a user on Windows launched Dolphin from the command line and specified a path to an M3U file and included backslashes in this path, Dolphin would fail to resolve relative paths in the M3U file.
JosJuice
force-pushed
the
m3u-backslash
branch
from
315d7f1 to
71f1b1d
Compare
|
IIRC the current policy in most of Dolphin is to fix up paths to not use backslashes as soon as they "enter" Dolphin, which is why SplitPath doesn't support backslashes. Currently the code that handles launching a game isn't replacing backslashes, but I suppose it would make sense to do so. Commit updated. |
delroth
approved these changes
Dec 24, 2022
Medard22
added a commit
to Medard22/Dolphin-MMJR2-VBI
that referenced
this pull request
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if a user on Windows launched Dolphin from the command line and specified a path to an M3U file and included backslashes in this path, Dolphin would fail to resolve relative paths in the M3U file.
Thanks to Tartifless on Discord for managing to narrow down the conditions under which the problem happens. I've heard reports every now and then about relative paths not working in M3U files ever since the M3U feature was added, but never managed to reproduce it.