DolphinAnalytics: Track support of framebuffer fetch #11396
Merged
+18
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwubcode
approved these changes
Jan 2, 2023
|
@iwubcode Thoughts on also adding logic ops to the analytics? Since fbfetch is one of the fallbacks for lack of logic ops support it would be good to have information about what devices support multiple implementations. |
|
I can't imagine adding that additional analytic would have any negative impact. And as you mentioned, having that data would be helpful. I say add it (either this PR or a new one, up to you) (as an aside, it would be helpful to add the url to the readme or somewhere else, as I never remember it) |
This was broken in 3570c7f.
GL_EXT_shader_framebuffer_fetch is not restricted to GLES (although GL_ARM_shader_framebuffer_fetch is), and is available on Intel GPUs.
Pokechu22
force-pushed
the
fbfetch-analytics
branch
from
19f2b89 to
c1b1d8d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the presence of fbfetch support to the analytics system. Based on #11387 it looks like fbfetch will be needed to accurately emulate blending behavior (impacting bloom in some games, as well as the menus in mario kart wii and a white box on fortune street, although we have a separate hack that fixes those), so it would be good to know how many users actually will have access to it.
This PR also checks for support of
GL_EXT_shader_framebuffer_fetchon regular OpenGL, instead of just OpenGL ES. Intel GPUs support it. I think the only effects of this are that ubershaders will use fbfetch and the fbfetch fallback becomes available if logic ops or dual source blend aren't supported. (Side note: it looks like analytics also tracks dual source blend support, but doesn't track logic ops support. Is that something worth adding?)