Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Common::ToUnderlying - DolphinQt FIFOAnalyzer #13453

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use Common::ToUnderlying - DolphinQt FIFOAnalyzer #13453

wants to merge 1 commit into from

Conversation

tygyh
Copy link
Contributor

@tygyh tygyh commented Mar 25, 2025 •
edited
Loading

This is the first step towards using the C++23 standard library method for converting an enum to its underlying type.

@jordan-woyak
Copy link
Member

I think some of our targets aren't really ready for C++23. You can use our Common::ToUnderlying for now.

@tygyh tygyh force-pushed the Use-underlying-method branch from 4f9e3bf to d2cc676 Compare March 25, 2025 20:26
@tygyh tygyh changed the title Use std::to_underlying - DolphinQt FIFOAnalyzer Use Common::ToUnderlying - DolphinQt FIFOAnalyzer Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jordan-woyak jordan-woyak jordan-woyak approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tygyh @jordan-woyak