Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stats safer encode #8379

Merged
merged 16 commits into from
Sep 24, 2024
Merged

Stats safer encode #8379

merged 16 commits into from
Sep 24, 2024

Conversation

max-hoffman
Copy link
Contributor

@max-hoffman max-hoffman commented Sep 24, 2024

We previously used commas as serialization boundaries for multi-field stats tuples (bucket bounds). That worked well for numeric values, and doesn't work well for strings with commas. This uses the prolly serialization code to more safely round trip tuples.

We still use commas to separate MCV counts, which are integers, and newlines (\n) for index types. If types can have newlines at some point we would want to switch that to prolly encoding as well.

@coffeegoddd
Copy link
Contributor

@max-hoffman DOLT

comparing_percentages
100.000000 to 100.000000
version result total
9746326 ok 5937457
version total_tests
9746326 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Contributor

@coffeegoddd DOLT

comparing_percentages
100.000000 to 100.000000
version result total
6ce6230 ok 5937457
version total_tests
6ce6230 5937457
correctness_percentage
100.0

@coffeegoddd
Copy link
Contributor

@max-hoffman DOLT

comparing_percentages
100.000000 to 100.000000
version result total
4a7e8ac ok 5937457
version total_tests
4a7e8ac 5937457
correctness_percentage
100.0

go/libraries/doltcore/sqle/statsnoms/iter.go Outdated Show resolved Hide resolved
@coffeegoddd
Copy link
Contributor

@max-hoffman DOLT

comparing_percentages
100.000000 to 100.000000
version result total
8437aa2 ok 5937457
version total_tests
8437aa2 5937457
correctness_percentage
100.0

@max-hoffman max-hoffman merged commit bd95816 into main Sep 24, 2024
21 checks passed
@max-hoffman max-hoffman deleted the max/stats-safer-encode branch September 24, 2024 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants