fix switcher successX #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dom96
requested changes
Jan 12, 2020
There was a problem hiding this comment.
I think a better approach now is to use gorgeEx: https://nim-lang.org/docs/system.html#gorgeEx%2Cstring%2Cstring%2Cstring and to check the exit code. Although maybe Nim doesn't return proper exit code(?)
|
done, PTAL |
|
LGTM |
timotheecour
force-pushed
the
pr_fix_switcher_successX
branch
from
4765f31
to
4e3e4d9
Compare
|
PTAL, rebased against latest |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes nim-lang/packages#1315 (comment) which happened because of nim-lang/Nim#13043
the fix is backward compatible since successX was shown also before