Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add extra feature "choosenim show path" #273

Merged
merged 4 commits into from
Oct 5, 2021
Merged

add extra feature "choosenim show path" #273

merged 4 commits into from
Oct 5, 2021

Conversation

ilmanzo
Copy link
Contributor

@ilmanzo ilmanzo commented Oct 4, 2021

fix #260

dom96
dom96 approved these changes Oct 5, 2021
View reviewed changes
Copy link
Owner

@dom96 dom96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks! If you have time for another PR: a test for this would be awesome.

src/choosenim.nim Outdated Show resolved Hide resolved
src/choosenim.nim Outdated Show resolved Hide resolved
src/choosenim.nim Outdated Show resolved Hide resolved
@dom96 dom96 merged commit 459f6c1 into dom96:master Oct 5, 2021
@ilmanzo
Copy link
Contributor Author

ilmanzo commented Oct 6, 2021

Nice, thanks! If you have time for another PR: a test for this would be awesome.

sure, please take a look at #276

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dom96 dom96 dom96 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"choosenim show path" command
2 participants
@ilmanzo @dom96