Fix SPF Record verification failing for domains with a label starting with "all" (#145) #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello ! There is already an issue and a commit for this bug (ricco386@2690627), but I discovered it independently and came up with a more complete fix.
My solution ensures that, if .all ever becomes a valid TLD, the parsing won't stop working again, because it ensures that what we're matching is really an
allmechanism and not part of some other mechanism.It also fixes another bug : the current regex only matches one term after the
all, so multiple "trailing" terms or random text with spaces are not ignored properly.