-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix RequestBodyFilterAnnotation and MultipleFromForm for MinimalApi #2963
Fix RequestBodyFilterAnnotation and MultipleFromForm for MinimalApi #2963
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2963 +/- ##
==========================================
+ Coverage 90.34% 90.38% +0.04%
==========================================
Files 72 72
Lines 2839 2851 +12
Branches 446 448 +2
==========================================
+ Hits 2565 2577 +12
Misses 274 274
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a test that shows the description in the attribute is rendered in the generated document please?
The test change here only checks it doesn't cause generation to fail.
It's tested in the test Apply_EnrichesRequestBodyMetadata_IfControllerParameterDecoratedWithSwaggerRequestBodyAttribute of the file AnnotationsRequestBodyFilterTests |
I feel we're still missing something in our coverage here, as if we were validating the generated content for a Minimal API using this we would have found this bug before now. |
Yeah.. I do agree, altough there is no test for any MinimalApi (Apart from the IntegrationTests). I do not know how to fit this missing tests in the library(You cannot do a MapGet if there is no app. I think that we must create an issue to test the different apis using MinimalApi |
A verification test from the websites should fit this sort of niche. If we had some in this area already, your addition would have caused a test to fail as the description would have changed, even if the original bug wasn't there. That suggests to me adding such a test would give us the coverage that the document is what we expect and draw attention to future changes to ensure they are intentional. |
Ok, I will add Verify test to the webSites and try to fit the current MinimalApi issues I found over Swashbuckle. |
…parameters in MinimalApis
This last commit also fixes #2912. @martincostello, I think that docummenting with AllOf solves the problem of MinimalApi, the parameters are being mapped correctly and the doubt is if it's the most appropiate solution |
src/Swashbuckle.AspNetCore.SwaggerGen/SwaggerGenerator/SwaggerGenerator.cs
Outdated
Show resolved
Hide resolved
…n there are more than 1 Body elements
src/Swashbuckle.AspNetCore.SwaggerGen/SwaggerGenerator/SwaggerGenerator.cs
Outdated
Show resolved
Hide resolved
src/Swashbuckle.AspNetCore.SwaggerGen/SwaggerGenerator/SwaggerGenerator.cs
Outdated
Show resolved
Hide resolved
…e there are more than one FromBody
src/Swashbuckle.AspNetCore.SwaggerGen/SwaggerGenerator/SwaggerGenerator.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Martin Costello <martin@martincostello.com>
@martincostello I do not know how the release notes are going to be generated (For the version 6.7.0) but the description of [Fix RequestBodyFilterAnnotation for Minimal API) is missing the multiple FromForms part |
They're auto-generated by GitHub and then I'll manually edit anything missing/incorrect. |
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [Swashbuckle.AspNetCore](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore) | `6.6.2` -> `6.7.0` | [![age](https://developer.mend.io/api/mc/badges/age/nuget/Swashbuckle.AspNetCore/6.7.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/nuget/Swashbuckle.AspNetCore/6.7.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/nuget/Swashbuckle.AspNetCore/6.6.2/6.7.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/nuget/Swashbuckle.AspNetCore/6.6.2/6.7.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>domaindrivendev/Swashbuckle.AspNetCore (Swashbuckle.AspNetCore)</summary> ### [`v6.7.0`](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/releases/tag/v6.7.0) ##### What's Changed - Allow Swagger UI CSS and JS paths to be configurable by [@​mag1art](https://togithub.com/mag1art) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2908](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2908) - Add `IncludeXmlCommentsForAssembly()` convience overload by [@​leotsarev](https://togithub.com/leotsarev) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2909](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2909) - Add snapshot tests using Verify by [@​keahpeters](https://togithub.com/keahpeters) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2929](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2929) - Add posibility to ignore properties in `[FromForm]` with `[SwaggerIgnore]` by [@​jgarciadelanoceda](https://togithub.com/jgarciadelanoceda) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2928](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2928) - Adding check for existing directory and creating if doesn't exist by [@​matt-lethargic](https://togithub.com/matt-lethargic) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2927](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2927) - Default null value on nullable types caused errors by [@​jgarciadelanoceda](https://togithub.com/jgarciadelanoceda) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2941](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2941) - Add additional Verify tests by [@​keahpeters](https://togithub.com/keahpeters) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2950](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2950) - Only apply a SchemaFilter to create the description on SwaggerUI by [@​jgarciadelanoceda](https://togithub.com/jgarciadelanoceda) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2943](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2943) - Add support for async filters by [@​mauve](https://togithub.com/mauve) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2938](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2938) - Fix package validation by [@​martincostello](https://togithub.com/martincostello) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2926](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2926) - Adding support for .NET 8 Model State attributes by [@​jgarciadelanoceda](https://togithub.com/jgarciadelanoceda) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2958](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2958) - Only set Exclusive Range when they are by [@​jgarciadelanoceda](https://togithub.com/jgarciadelanoceda) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2960](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2960) - `[AsParameters]` throwing error on cast when showing the description with `EnableAnnotations()` by [@​jgarciadelanoceda](https://togithub.com/jgarciadelanoceda) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2962](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2962) - Fix `RequestBodyFilterAnnotation` and `MultipleFromForm` for Minimal APIs by [@​jgarciadelanoceda](https://togithub.com/jgarciadelanoceda) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2963](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2963) - Swagger UI refactoring by [@​martincostello](https://togithub.com/martincostello) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2942](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2942) - Add help wanted badge by [@​martincostello](https://togithub.com/martincostello) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2911](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2911) - Move inline css and js to external files for SwaggerUI and ReDoc by [@​junior-santana](https://togithub.com/junior-santana) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2965](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2965) - Missing properties section when generating `IFomFile`/`IFormFileCollection` by [@​jgarciadelanoceda](https://togithub.com/jgarciadelanoceda) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2972](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2972) - Missing Encoding and RequiredProperties when `IFormFile` with OpenAPI by [@​jgarciadelanoceda](https://togithub.com/jgarciadelanoceda) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2979](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2979) - Use `ApiParameter.Type` by [@​jgarciadelanoceda](https://togithub.com/jgarciadelanoceda) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2980](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2980) - Document arrays of generic parameters with XML comments and support overload methods by [@​jgarciadelanoceda](https://togithub.com/jgarciadelanoceda) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2982](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2982) - Take into account \[JsonRequired] for System.Text.Json by [@​jgarciadelanoceda](https://togithub.com/jgarciadelanoceda) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2988](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2988) - Configure non-nullable types as required by [@​AntiGuideAkquinet](https://togithub.com/AntiGuideAkquinet) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2803](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2803) - Use `HttpMethods.IsGet()` by [@​martincostello](https://togithub.com/martincostello) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2971](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2971) ##### New Contributors - [@​mag1art](https://togithub.com/mag1art) made their first contribution in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2908](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2908) - [@​jgarciadelanoceda](https://togithub.com/jgarciadelanoceda) made their first contribution in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2928](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2928) - [@​matt-lethargic](https://togithub.com/matt-lethargic) made their first contribution in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2927](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2927) - [@​mauve](https://togithub.com/mauve) made their first contribution in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2938](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2938) - [@​junior-santana](https://togithub.com/junior-santana) made their first contribution in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2965](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2965) - [@​AntiGuideAkquinet](https://togithub.com/AntiGuideAkquinet) made their first contribution in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2803](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2803) **Full Changelog**: domaindrivendev/Swashbuckle.AspNetCore@v6.6.2...v6.7.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 10pm every weekday,every weekend,before 5am every weekday" in timezone Europe/Berlin, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/orso-co/Orso.Arpa.Api). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuNyIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC43IiwidGFyZ2V0QnJhbmNoIjoiZGV2ZWxvcCIsImxhYmVscyI6W119--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [Swashbuckle.AspNetCore](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore) | `6.6.2` -> `6.7.3` | [![age](https://developer.mend.io/api/mc/badges/age/nuget/Swashbuckle.AspNetCore/6.7.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/nuget/Swashbuckle.AspNetCore/6.7.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/nuget/Swashbuckle.AspNetCore/6.6.2/6.7.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/nuget/Swashbuckle.AspNetCore/6.6.2/6.7.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [Swashbuckle.AspNetCore.Annotations](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore) | `6.6.2` -> `6.7.3` | [![age](https://developer.mend.io/api/mc/badges/age/nuget/Swashbuckle.AspNetCore.Annotations/6.7.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/nuget/Swashbuckle.AspNetCore.Annotations/6.7.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/nuget/Swashbuckle.AspNetCore.Annotations/6.6.2/6.7.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/nuget/Swashbuckle.AspNetCore.Annotations/6.6.2/6.7.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>domaindrivendev/Swashbuckle.AspNetCore (Swashbuckle.AspNetCore)</summary> ### [`v6.7.3`](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/releases/tag/v6.7.3) ##### What's Changed - Fix nested types nullable context check by [@​VladimirTyrin](https://togithub.com/VladimirTyrin) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/3043](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/3043) - Use NullabilityInfoContext to determine if member is nullable by [@​patrikwlund](https://togithub.com/patrikwlund) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/3046](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/3046) ##### New Contributors - [@​VladimirTyrin](https://togithub.com/VladimirTyrin) made their first contribution in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/3043](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/3043) **Full Changelog**: domaindrivendev/Swashbuckle.AspNetCore@v6.7.2...v6.7.3 ### [`v6.7.2`](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/releases/tag/v6.7.2) #### What's Changed - Use NullabilityInfoContext to determine dictionary value nullability by [@​patrikwlund](https://togithub.com/patrikwlund) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/3041](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/3041) **Full Changelog**: domaindrivendev/Swashbuckle.AspNetCore@v6.7.1...v6.7.2 ### [`v6.7.1`](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/releases/tag/v6.7.1) #### What's Changed - docs: Update README.md by [@​WeihanLi](https://togithub.com/WeihanLi) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/3002](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/3002) - Support `[DataMember]` `IsRequired` in `NewtonsoftDataContractResolver` by [@​ouvreboite](https://togithub.com/ouvreboite) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2644](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2644) - Add API analysers by [@​martincostello](https://togithub.com/martincostello) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/3003](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/3003) - Update README by [@​martincostello](https://togithub.com/martincostello) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/3004](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/3004) - docs: fix example code formatting by [@​WeihanLi](https://togithub.com/WeihanLi) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/3010](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/3010) - Fixes nullability problems with dictionaries by [@​ozziepeeps](https://togithub.com/ozziepeeps) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/3023](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/3023) - Fix handling of nullable structs by [@​martincostello](https://togithub.com/martincostello) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/3015](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/3015) - Fix missing form parameter XML documentation by [@​martincostello](https://togithub.com/martincostello) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/3020](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/3020) #### New Contributors - [@​ouvreboite](https://togithub.com/ouvreboite) made their first contribution in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2644](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2644) **Full Changelog**: domaindrivendev/Swashbuckle.AspNetCore@v6.7.0...v6.7.1 ### [`v6.7.0`](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/releases/tag/v6.7.0) #### What's Changed - Allow Swagger UI CSS and JS paths to be configurable by [@​mag1art](https://togithub.com/mag1art) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2908](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2908) - Add `IncludeXmlCommentsForAssembly()` convience overload by [@​leotsarev](https://togithub.com/leotsarev) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2909](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2909) - Add snapshot tests using Verify by [@​keahpeters](https://togithub.com/keahpeters) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2929](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2929) - Add posibility to ignore properties in `[FromForm]` with `[SwaggerIgnore]` by [@​jgarciadelanoceda](https://togithub.com/jgarciadelanoceda) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2928](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2928) - Adding check for existing directory and creating if doesn't exist by [@​matt-lethargic](https://togithub.com/matt-lethargic) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2927](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2927) - Default null value on nullable types caused errors by [@​jgarciadelanoceda](https://togithub.com/jgarciadelanoceda) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2941](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2941) - Add additional Verify tests by [@​keahpeters](https://togithub.com/keahpeters) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2950](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2950) - Only apply a SchemaFilter to create the description on SwaggerUI by [@​jgarciadelanoceda](https://togithub.com/jgarciadelanoceda) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2943](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2943) - Add support for async filters by [@​mauve](https://togithub.com/mauve) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2938](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2938) - Fix package validation by [@​martincostello](https://togithub.com/martincostello) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2926](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2926) - Adding support for .NET 8 Model State attributes by [@​jgarciadelanoceda](https://togithub.com/jgarciadelanoceda) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2958](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2958) - Only set Exclusive Range when they are by [@​jgarciadelanoceda](https://togithub.com/jgarciadelanoceda) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2960](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2960) - `[AsParameters]` throwing error on cast when showing the description with `EnableAnnotations()` by [@​jgarciadelanoceda](https://togithub.com/jgarciadelanoceda) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2962](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2962) - Fix `RequestBodyFilterAnnotation` and `MultipleFromForm` for Minimal APIs by [@​jgarciadelanoceda](https://togithub.com/jgarciadelanoceda) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2963](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2963) - Swagger UI refactoring by [@​martincostello](https://togithub.com/martincostello) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2942](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2942) - Add help wanted badge by [@​martincostello](https://togithub.com/martincostello) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2911](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2911) - Move inline css and js to external files for SwaggerUI and ReDoc by [@​junior-santana](https://togithub.com/junior-santana) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2965](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2965) - Missing properties section when generating `IFomFile`/`IFormFileCollection` by [@​jgarciadelanoceda](https://togithub.com/jgarciadelanoceda) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2972](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2972) - Missing Encoding and RequiredProperties when `IFormFile` with OpenAPI by [@​jgarciadelanoceda](https://togithub.com/jgarciadelanoceda) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2979](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2979) - Use `ApiParameter.Type` by [@​jgarciadelanoceda](https://togithub.com/jgarciadelanoceda) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2980](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2980) - Document arrays of generic parameters with XML comments and support overload methods by [@​jgarciadelanoceda](https://togithub.com/jgarciadelanoceda) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2982](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2982) - Take into account \[JsonRequired] for System.Text.Json by [@​jgarciadelanoceda](https://togithub.com/jgarciadelanoceda) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2988](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2988) - Configure non-nullable types as required by [@​AntiGuideAkquinet](https://togithub.com/AntiGuideAkquinet) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2803](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2803) - Use `HttpMethods.IsGet()` by [@​martincostello](https://togithub.com/martincostello) in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2971](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2971) #### New Contributors - [@​mag1art](https://togithub.com/mag1art) made their first contribution in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2908](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2908) - [@​jgarciadelanoceda](https://togithub.com/jgarciadelanoceda) made their first contribution in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2928](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2928) - [@​matt-lethargic](https://togithub.com/matt-lethargic) made their first contribution in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2927](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2927) - [@​mauve](https://togithub.com/mauve) made their first contribution in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2938](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2938) - [@​junior-santana](https://togithub.com/junior-santana) made their first contribution in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2965](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2965) - [@​AntiGuideAkquinet](https://togithub.com/AntiGuideAkquinet) made their first contribution in [https://github.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2803](https://togithub.com/domaindrivendev/Swashbuckle.AspNetCore/pull/2803) **Full Changelog**: domaindrivendev/Swashbuckle.AspNetCore@v6.6.2...v6.7.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 9pm,before 6am" in timezone Europe/Zurich, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/smartive/cas-fee-adv-mumble-api). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuNyIsInVwZGF0ZWRJblZlciI6IjM4LjU2LjAiLCJ0YXJnZXRCcmFuY2giOiJtYWluIiwibGFiZWxzIjpbImRlcGVuZGVuY2llcyJdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Fixes #2662. Very similar to #2962 PR. When the RequestBody had a SwaggerRequestBody attribute the attribute was not applying and it provoked an exception