Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump github.com/PuerkitoBio/goquery from 1.9.2 to 1.10.1 #420

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 30, 2024

Bumps github.com/PuerkitoBio/goquery from 1.9.2 to 1.10.1.

Release notes

Sourced from github.com/PuerkitoBio/goquery's releases.

v1.10.1

Update go.mod dependencies.

v1.10.0

Add EachIter which provides an iterator that can be used in for..range loops on the *Selection object.

goquery now requires Go version 1.23+, use goquery v1.9.x for older Go versions.

v1.9.3

Update go.mod dependencies.

Commits
  • 1da3b30 Merge pull request #503 from iamleot/prepare-for-v1.10.1
  • 985aab3 Prepare for version v1.10.1
  • b995434 Merge pull request #502 from PuerkitoBio/dependabot/go_modules/github.com/and...
  • 381d6b9 Bump github.com/andybalholm/cascadia from 1.3.2 to 1.3.3
  • 69f0ce2 Merge pull request #501 from PuerkitoBio/dependabot/go_modules/golang.org/x/n...
  • 4075868 Bump golang.org/x/net from 0.32.0 to 0.33.0
  • 13c6a0c Merge pull request #499 from PuerkitoBio/dependabot/go_modules/golang.org/x/n...
  • 0f6e1ad Bump golang.org/x/net from 0.31.0 to 0.32.0
  • 3d8242f Merge pull request #496 from PuerkitoBio/dependabot/go_modules/golang.org/x/n...
  • 41a8923 Bump golang.org/x/net from 0.30.0 to 0.31.0
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Dec 30, 2024
Bumps [github.com/PuerkitoBio/goquery](https://github.com/PuerkitoBio/goquery) from 1.9.2 to 1.10.1.
- [Release notes](https://github.com/PuerkitoBio/goquery/releases)
- [Commits](PuerkitoBio/goquery@v1.9.2...v1.10.1)

---
updated-dependencies:
- dependency-name: github.com/PuerkitoBio/goquery
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/PuerkitoBio/goquery-1.10.1 branch from 807263b to 80900ff Compare January 6, 2025 18:04
@case-fastly
Copy link
Contributor

@cee-dub it looks like this is wanting go.mod to bump to Go 1.23:

$ go mod tidy

go: downloading github.com/PuerkitoBio/goquery v1.10.1

$ git diff

diff --git a/go.mod b/go.mod
index 3ac6940..13ba22c 100644
--- a/go.mod
+++ b/go.mod
@@ -1,6 +1,7 @@
 module github.com/domainr/whois

-go 1.21
+go 1.23
+
 toolchain go1.23.4

 require (
(END)

@cee-dub
Copy link
Member

cee-dub commented Jan 6, 2025

v1.10.0

Add EachIter which provides an iterator that can be used in for..range loops on the *Selection object.

goquery now requires Go version 1.23+, use goquery v1.9.x for older Go versions.

We have two options:

  1. We could stay at the older version by telling dependabot to ignore this.

  2. We could bump our go version requirement

@case-fastly
Copy link
Contributor

Fwiw, I tend to lean toward Staying Current, because Hygiene. Unless there are worthwhile reasons to not stay current, of course.

@case-fastly
Copy link
Contributor

@cee-dub looks like we have the same issue here: zonedb/zonedb#1017

@cee-dub
Copy link
Member

cee-dub commented Jan 6, 2025

Agree, I think it is fine to bump these, since consumers retain the choice of remaining on an older version.

@case-fastly
Copy link
Contributor

@cee-dub sounds good, I'll update this one, and ZoneDB as well, if that works for you?

@case-fastly case-fastly merged commit 74b4f25 into main Jan 6, 2025
2 checks passed
@case-fastly case-fastly deleted the dependabot/go_modules/github.com/PuerkitoBio/goquery-1.10.1 branch January 6, 2025 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants