Skip to content
This repository has been archived by the owner on Oct 12, 2023. It is now read-only.

Exclude from camelization all-uppercase keys #20

Closed
wants to merge 1 commit into from

Conversation

GiovanniFrigo
Copy link

I do believe that all-uppercase keys should not be camelized, as they probably are acronyms.

Think for example to keys like "ID" or "UUID": if camelized, they do became "iD" and "uUID" respectively.

@GiovanniFrigo GiovanniFrigo changed the title Exclude from camelization keys which are all uppercase Exclude from camelization all-uppercase keys Dec 4, 2015
@CompuIves
Copy link

Came here to make exactly the same PR, I have this problem currently with currency codes which are wrongly converted (EUR -> eUR).

@calvn
Copy link

calvn commented Feb 2, 2016

What is the status on this PR? I mentioned this issue on #24, and I am fine with not camelizing acronyms at all. Is there a suggested workaround for this in the meantime?

@GiovanniFrigo
Copy link
Author

Author has not yet responded/reviewed this PR, I don't know if he's still active or not.
Meanwhile, you can use the library I forked and patched at GiovanniFrigo/humps

@domchristie
Copy link
Owner

Hi All,

Thanks for your interest, and apologies for the delay. For the last couple of months I have been spending my time sorting out my new flat so my free time has been limited.

I’ll respond properly when I can.

Thanks again.

@domchristie
Copy link
Owner

Thanks for this. I believe this can now be closed as a result of #28. Thanks again.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants