CON-8711 - RP | In-use | Not MVP | add enable/disable to terraform module (sdk) #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -55,6 +56,11 @@ type ImageAssuranceEnableRequest struct { | |||
| Enabled bool `json:"enabled"` | |||
| } | |||
|
|
|||
| type ImageAccessRuntimeMonitorEnableRequest struct { | |||
| CloudAccountId string `json:"cloudAccountId"` | |||
There was a problem hiding this comment.
why is the json here "cloudAccountId" and at other places its "k8sAccountId"? can we make it consistent?
There was a problem hiding this comment.
actually I took example from ImageAssurance in all places. 4 lines above, it has "cloudAccountId"
There was a problem hiding this comment.
yes, I see that.
I think we can take the opportunity and change both of them to be like the others. but it's up to you to decide.
chkp-stanislavz
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.