Added page.clipRect for rasterizing via PhantomJS #45
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might be an issue specific for my platform (running on Node.js v5.10.1 on a Gentoo box), but I need to have settings for
page.clipRect
(docs here) in place as well (alongside withpage.viewportSize
) to make the rendered PNG have the correct dimensions. IfclipRect
is missing, there will always be PhantomJS' default dimensions (400 x 300 px) kicking in for the sides being less than these defaults. I.e. an SVG supposed to render as 500 x 100 px will end up being 500 x 300 px, and a 100 x 500 px one will end up with 400 x 500 px. Thepage.clipRect
might not be necessary for other platforms, but I don't see any harm for them either.