Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: fix method NewQuaiBackend #2410

Closed
wants to merge 2 commits into from
Closed

feat: fix method NewQuaiBackend #2410

wants to merge 2 commits into from

Conversation

GalaxiesCN
Copy link
Contributor

No description provided.

Djadih
Djadih requested changes Jan 3, 2025
View reviewed changes
Copy link
Contributor

@Djadih Djadih left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The repo doesn't allow merge commits. Please rebase and then try to merge. One of us can also do it for you if you like.

@GalaxiesCN
Copy link
Contributor Author

The repo doesn't allow merge commits. Please rebase and then try to merge. One of us can also do it for you if you like.

Thanks for taking a look!

@GalaxiesCN GalaxiesCN requested a review from Djadih January 7, 2025 03:14
@Djadih
Copy link
Contributor

Djadih commented Jan 20, 2025

@GalaxiesCN sorry it added another merge commit. Can you rebase and ping us to review? We'll wait a few days and then if not done I'll push it on your behalf in a separate PR.

gameofpointers added a commit to gameofpointers/go-quai that referenced this pull request Jan 20, 2025
@gameofpointers
bugfix: use MaxRegions variable for the region api backends
3f3f9f2 
Initially noted by: dominant-strategies#2410
@gameofpointers gameofpointers mentioned this pull request Jan 20, 2025
Merged
@gameofpointers
Copy link
Contributor

#2469

closing it because i made a PR with this fix and referenced this PR in the commit messagte

@GalaxiesCN
Copy link
Contributor Author

@GalaxiesCN sorry it added another merge commit. Can you rebase and ping us to review? We'll wait a few days and then if not done I'll push it on your behalf in a separate PR.

idk why close this pr with a new pr🤷🏻‍♀️ anyway #2430 is already been rebased @Djadih

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdowning100 jdowning100 jdowning100 approved these changes

@gameofpointers gameofpointers gameofpointers approved these changes

@wizeguyy wizeguyy Awaiting requested review from wizeguyy wizeguyy is a code owner

@kiltsonfire kiltsonfire Awaiting requested review from kiltsonfire kiltsonfire is a code owner

@Djadih Djadih Awaiting requested review from Djadih

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GalaxiesCN @Djadih @gameofpointers @jdowning100