Fix lint errors #763
Fix lint errors #763
Conversation
hubchub
requested review from
wizeguyy,
kiltsonfire and
gameofpointers
as code owners
hubchub
force-pushed
the
fix-lint-errors
branch
from
9052add
to
d44f3f4
Compare
| @@ -20,7 +20,7 @@ import ( | |||
| "context" | |||
| "sync" | |||
|
|
|||
| "github.com/dominant-strategies/go-quai" | |||
| ethereum "github.com/dominant-strategies/go-quai" | |||
There was a problem hiding this comment.
I don't understand this addition. Any idea why the linter added this?
There was a problem hiding this comment.
Yeah looks strange, maybe the "name" of our package is ethereum somewhere still?
They implemented this auto alias feature golangci/golangci-lint#2401
hubchub
force-pushed
the
fix-lint-errors
branch
from
d44f3f4
to
7c8169f
Compare
| @@ -1047,7 +1047,7 @@ func (d *Downloader) processHeaders(origin uint64) error { | |||
| if rollback > 0 { | |||
| curBlock := d.core.CurrentBlock().NumberU64() | |||
| log.Warn("Rolled back chain segment", | |||
| "block", fmt.Sprintf("%d->%d", curBlock), "reason", rollbackErr) | |||
| "block", fmt.Sprintf("%d->%d", curBlock, rollbackErr), "reason") | |||
There was a problem hiding this comment.
Neither of these print statements look correct, lol. I don't think this is the linters fault, but just want to check with you first
|
@hubchub what is the status on this? IIRC you were adding some of the tests back in |
hubchub
force-pushed
the
fix-lint-errors
branch
from
7c8169f
to
8101ccd
Compare
hubchub
force-pushed
the
fix-lint-errors
branch
from
8101ccd
to
8d643fb
Compare
|
reintroduced the tests and rebased on main the linter is failing but only on test files |
| tc.evictedVals = append(tc.evictedVals, v) | ||
| } | ||
| // outside critical section | ||
| //func (tc *TimedCache) onEvicted(k, v interface{}) { |
There was a problem hiding this comment.
If this function isn't being used then we should probably remove it
| for i, blockHash := range pendingBlockBody.SubManifest { | ||
| subManifest[i] = blockHash | ||
| } | ||
| copy(subManifest, pendingBlockBody.SubManifest) |
There was a problem hiding this comment.
Just seeing this so often I wonder if there was any reason we manually set each element instead of using copy. @gameofpointers any thoughts?
| // and delete all the data associated with the snapshot (accounts, storage, | ||
| // metadata). After all is done, the snapshot range of the database is compacted | ||
| // to free up unused data blocks. | ||
| func wipeSnapshot(db ethdb.KeyValueStore, full bool) chan struct{} { |
There was a problem hiding this comment.
Probably will need this code relatively soon. Still delete but bringing it to everyone's attention @dominant-strategies/core-dev
| @@ -541,6 +541,7 @@ func (pool *TxPool) TxPoolPending(enforceTips bool, etxSet types.EtxSet) (map[co | |||
| } | |||
| } | |||
|
|
|||
| //nolint | |||
| @@ -29,7 +29,7 @@ import ( | |||
| "github.com/dominant-strategies/go-quai/crypto/bn256" | |||
| "github.com/dominant-strategies/go-quai/params" | |||
|
|
|||
| //lint:ignore SA1019 Needed for precompile | |||
| //nolint SA1019 Needed for precompile | |||
| @@ -284,7 +284,7 @@ func (evm *EVM) CallCode(caller ContractRef, addr common.Address, input []byte, | |||
| // The contract is a scoped environment for this execution context only. | |||
| contract := NewContract(caller, AccountRef(caller.Address()), value, gas) | |||
| contract.SetCallCode(&addrCopy, evm.StateDB.GetCodeHash(internalAddr), evm.StateDB.GetCode(internalAddr)) | |||
| ret, err = evm.interpreter.Run(contract, input, false) | |||
| ret, _ = evm.interpreter.Run(contract, input, false) | |||
There was a problem hiding this comment.
Do these need error checking blocks?
There was a problem hiding this comment.
I don't think we need this whole blake2b directory anymore
| @@ -20,7 +20,7 @@ import ( | |||
| "context" | |||
| "sync" | |||
|
|
|||
| "github.com/dominant-strategies/go-quai" | |||
| ethereum "github.com/dominant-strategies/go-quai" | |||
There was a problem hiding this comment.
Yeah looks strange, maybe the "name" of our package is ethereum somewhere still?
They implemented this auto alias feature golangci/golangci-lint#2401
|
closing this for now. We can reopen when we're ready to restart this effort |
@dominant-strategies/core-dev