Adds support for #82's conclusion. #85
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for the file extensions and for parsers by specific extension. All tests pass and a new one was added to test the extensions.
This was referenced Aug 14, 2016
|
I think that it should be semver-major given that it breaks anyone using a custom parser because now the custom parsers are objects. |
| var configs = [defaults] | ||
| var configFiles = [] | ||
| function addConfigFile (file) { | ||
| if (configFiles.indexOf(file) >= 0) return | ||
| var fileConfig = cc.file(file) | ||
| if (fileConfig) { | ||
| configs.push(parse(fileConfig)) | ||
| configs.push(cc.parse(fileConfig, file, parsers)) |
There was a problem hiding this comment.
I kind of think that the parse function should be created inside the main function. I did it this way so that test/ini.js still passed.
|
@dominictarr if I updated this PR would you be amicable to merging? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for the file extensions and for parsers by specific extension. All tests pass and a new one was added to test the extensions. This will probably be a major semver change so that was reflected in the package.json. Closes #82.