Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Does it also work when used with MenuItem? #11

Closed
SwederSchellens opened this issue Jan 13, 2020 · 4 comments
Closed

Does it also work when used with MenuItem? #11

SwederSchellens opened this issue Jan 13, 2020 · 4 comments

Comments

@SwederSchellens
Copy link

SwederSchellens commented Jan 13, 2020 •
edited
Loading

Hi,

Thanks for providing this great component.

I have it working when used with Button. But I would like to also use it with MaterialUI MenuItem but so far I did't get it to work. Is it supposed to work with MenuItem?

Cheers.
@dominikbulaj
Copy link
Owner

@SwederSchellens you mean MaterialUI MenuItem?

@SwederSchellens
Copy link
Author

Yes. Sorry for not being clear about that.

@dominikbulaj
Copy link
Owner

Yeah, it's not possible at the moment. I'm gonna expose onClick property that will help resolve this and similar issues.

dominikbulaj added a commit that referenced this issue Jan 14, 2020
@dominikbulaj
Optional onClick property available (resolves #11)
3c8a67e
@dominikbulaj
Copy link
Owner

@SwederSchellens I've added onClick callback in v1.7.0
Please see this example https://codesandbox.io/s/loving-cookies-6no9o

@dominikbulaj dominikbulaj mentioned this issue Apr 24, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dominikbulaj @SwederSchellens