Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pinning version of Django for library #186

Merged
merged 2 commits into from
Feb 14, 2020
Merged

Fix pinning version of Django for library #186

merged 2 commits into from
Feb 14, 2020

Conversation

DmytroLitvinov
Copy link
Collaborator

No description provided.

@DmytroLitvinov DmytroLitvinov self-assigned this Feb 14, 2020
@dominno
Copy link
Owner

dominno commented Feb 14, 2020

@DmytroLitvinov I think you have to change something else as tests are failing

@DmytroLitvinov DmytroLitvinov force-pushed the fix-versions branch 6 times, most recently from 9f2a337 to cf3c011 Compare February 14, 2020 20:43
@DmytroLitvinov
Copy link
Collaborator Author

DmytroLitvinov commented Feb 14, 2020 •
edited
Loading

@dominno they are failing on django 1.11 because of django-model-utils library which requires django>=2.0.1 starting from v4 of library.

As I see in project, we are using django-model-utils just for Choices. Maybe we should get rid of that library and use internal Django's choices?

@DmytroLitvinov DmytroLitvinov merged commit 9bac8b8 into master Feb 14, 2020
@DmytroLitvinov
Copy link
Collaborator Author

Related to #187

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@DmytroLitvinov DmytroLitvinov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DmytroLitvinov @dominno