Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove prune setting for eks cluster #105

Merged
merged 2 commits into from
Aug 12, 2022
Merged

remove prune setting for eks cluster #105

merged 2 commits into from
Aug 12, 2022

Conversation

steved
Copy link
Contributor

@steved steved commented Aug 10, 2022

AWS-CDK's lambda for generic kubernetes manifests doesn't support 1.22 officially so prune bails on the missing API versions (like ingress). This occurs during updates to an existing cluster. If/when we update Calico, this may affect how the upgrades from one version to another works.

See aws/aws-cdk#19843 for more context. aws/aws-cdk#15736 (comment) does indicate a workaround, but it doesn't seem very palatable.

deployer_image: quay.io/domino/deployer:steved-destroy-deploy.latest

@steved steved added the deploy-test Run Deployment Tests label Aug 10, 2022
@steved
Copy link
Contributor Author

steved commented Aug 12, 2022

Tested with a successful deploy of 1.22 on master. Adding a new unmanaged node group and cdk deploy results in:

Received response status [FAILED] from custom resource. Message returned: Error: b'configmap/aws-auth configured\nerror: error retrieving RESTMappings to prune: invalid resource extensions/v1beta1, Kind=Ingress, Namespaced=true: no matches for kind "Ingress" in version "extensions/v1beta1"\n' Logs: /aws/lambda/steved-cdk-1-EksStackNestedStackEk-Handler886CB40B-2ak0Zp34wmv1 at invokeUserFunction (/var/task/framework.js:96:19) at processTicksAndRejections (internal/process/task_queues.js:97:5) at async onEvent (/var/task/framework.js:19:27) at async Runtime.handler (/var/task/cfn-response.js:48:13) (RequestId: 89089f1c-1801-4430-9479-200c70529c8e)

With this change, it completes successfully.

@steved steved marked this pull request as ready for review August 12, 2022 19:25
@steved steved merged commit 170791b into master Aug 12, 2022
@steved steved deleted the steved/rm-prune branch August 12, 2022 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy-test Run Deployment Tests
Development

Successfully merging this pull request may close these issues.

2 participants