QE-11629 publish and launch p2 #528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove unneeded libs - replace black with ruff - remove detect-secrets to be replaced by GH repo security - remove bandit to be replaced by GH CodeQL - cleanup makefile - bump version
ddl-cedricyoung
requested review from
ddl-kgarton and
ddl-kavya
and removed request for
a team
|
@ddl-cedricyoung Happy to approve. But does red CI indicate a problem that should be fixed in this branch? |
@mikesbrown The CI issue is ongoing instability with our multiprocessing (sometimes it takes way longer to spin up workers) and not related to this PR. |
ddl-kgarton
approved these changes
Sep 12, 2024
Thanks @ddl-cedricyoung . Happy to approve others with this knowledge. Keep 'em comin'! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: https://dominodatalab.atlassian.net/browse/QE-11629
What is the new behavior?
Does this PR introduce a breaking change?
Other information
I'll have a followup PR to test the GH workflows for publishing