Skip to content

Commit

Permalink
update golangci-lint and controller-tools
Browse files Browse the repository at this point in the history
  • Loading branch information
@steved
steved committed Apr 18, 2024
1 parent d20c470 commit d9afa13
Show file tree
Hide file tree
Showing 8 changed files with 466 additions and 508 deletions.
8 changes: 5 additions & 3 deletions .golangci.yml
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
run:
timeout: 5m
tests: false
skip-files:
issues:
exclude-files:
- cribbed.go
- "zz_generated.*"
linters-settings:
Expand Down Expand Up @@ -52,8 +53,8 @@ linters:
- forbidigo
- forcetypeassert
- gci
- gochecknoinits
- gochecknoglobals
- gochecknoinits
- gocognit
- godot
- godox
Expand All @@ -65,11 +66,12 @@ linters:
- interfacer
- ireturn
- maligned
- nestif
- nlreturn
- nonamedreturns
- nosnakecase
- nosprintfhostport
- nestif
- perfsprint
- prealloc
- scopelint
- structcheck
Expand Down
36 changes: 21 additions & 15 deletions deployments/crds/hephaestus.dominodatalab.com_imagebuildmessages.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.13.0
controller-gen.kubebuilder.io/version: v0.14.0
name: imagebuildmessages.hephaestus.dominodatalab.com
spec:
group: hephaestus.dominodatalab.com
Expand All @@ -21,14 +21,19 @@ spec:
openAPIV3Schema:
properties:
apiVersion:
description: 'APIVersion defines the versioned schema of this representation
of an object. Servers should convert recognized schemas to the latest
internal value, and may reject unrecognized values. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#resources'
description: |-
APIVersion defines the versioned schema of this representation of an object.
Servers should convert recognized schemas to the latest internal value, and
may reject unrecognized values.
More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#resources
type: string
kind:
description: 'Kind is a string value representing the REST resource this
object represents. Servers may infer this from the endpoint the client
submits requests to. Cannot be updated. In CamelCase. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#types-kinds'
description: |-
Kind is a string value representing the REST resource this object represents.
Servers may infer this from the endpoint the client submits requests to.
Cannot be updated.
In CamelCase.
More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#types-kinds
type: string
metadata:
type: object
Expand Down Expand Up @@ -56,11 +61,12 @@ spec:
items:
properties:
message:
description: "ImageBuildStatusTransitionMessage contains information
about ImageBuild status transitions. \n This type is used
to publish JSON-formatted messages to one or more configured
messaging endpoints when ImageBuild resources undergo phase
changes during the build process."
description: |-
ImageBuildStatusTransitionMessage contains information about ImageBuild status transitions.
This type is used to publish JSON-formatted messages to one or more configured messaging
endpoints when ImageBuild resources undergo phase changes during the build process.
properties:
annotations:
additionalProperties:
Expand All @@ -75,9 +81,9 @@ spec:
when one occurs.
type: string
imageURLs:
description: ImageURLs contains a list of fully-qualified
registry images. This field is only populated when an
ImageBuild transitions to PhaseSucceeded.
description: |-
ImageURLs contains a list of fully-qualified registry images.
This field is only populated when an ImageBuild transitions to PhaseSucceeded.
items:
type: string
type: array
Expand Down
104 changes: 54 additions & 50 deletions deployments/crds/hephaestus.dominodatalab.com_imagebuilds.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
annotations:
controller-gen.kubebuilder.io/version: v0.13.0
controller-gen.kubebuilder.io/version: v0.14.0
name: imagebuilds.hephaestus.dominodatalab.com
spec:
group: hephaestus.dominodatalab.com
Expand Down Expand Up @@ -38,14 +38,19 @@ spec:
openAPIV3Schema:
properties:
apiVersion:
description: 'APIVersion defines the versioned schema of this representation
of an object. Servers should convert recognized schemas to the latest
internal value, and may reject unrecognized values. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#resources'
description: |-
APIVersion defines the versioned schema of this representation of an object.
Servers should convert recognized schemas to the latest internal value, and
may reject unrecognized values.
More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#resources
type: string
kind:
description: 'Kind is a string value representing the REST resource this
object represents. Servers may infer this from the endpoint the client
submits requests to. Cannot be updated. In CamelCase. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#types-kinds'
description: |-
Kind is a string value representing the REST resource this object represents.
Servers may infer this from the endpoint the client submits requests to.
Cannot be updated.
In CamelCase.
More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#types-kinds
type: string
metadata:
type: object
Expand Down Expand Up @@ -109,10 +114,9 @@ spec:
type: string
type: object
cloudProvided:
description: 'NOTE: this field was previously used to determine
whether to fetch credentials from the cloud a given server.
this is now done automatically and this field is no longer
necessary.'
description: |-
NOTE: this field was previously used to determine whether to fetch credentials from the cloud a given server.
this is now done automatically and this field is no longer necessary.
type: boolean
secret:
properties:
Expand All @@ -122,14 +126,12 @@ spec:
type: string
type: object
server:
description: 'NOTE: this field was previously used to assert
the presence of an auth entry inside of secret credentials.
if the Server was missing, then an error was raised. this
design is limiting because it requires users to create several
`registryAuth` items with the same secret if they want to
verify the presence. in a future api version, we may remove
the Server field from this type and replace it with one or
more fields that service the needs all credential types.'
description: |-
NOTE: this field was previously used to assert the presence of an auth entry inside of secret credentials. if the
Server was missing, then an error was raised. this design is limiting because it requires users to create
several `registryAuth` items with the same secret if they want to verify the presence. in a future api version,
we may remove the Server field from this type and replace it with one or more fields that service the needs all
credential types.
type: string
type: object
type: array
Expand Down Expand Up @@ -166,42 +168,42 @@ spec:
conditions:
items:
description: "Condition contains details for one aspect of the current
state of this API Resource. --- This struct is intended for direct
use as an array at the field path .status.conditions. For example,
\n type FooStatus struct{ // Represents the observations of a
foo's current state. // Known .status.conditions.type are: \"Available\",
\"Progressing\", and \"Degraded\" // +patchMergeKey=type // +patchStrategy=merge
// +listType=map // +listMapKey=type Conditions []metav1.Condition
`json:\"conditions,omitempty\" patchStrategy:\"merge\" patchMergeKey:\"type\"
protobuf:\"bytes,1,rep,name=conditions\"` \n // other fields }"
state of this API Resource.\n---\nThis struct is intended for
direct use as an array at the field path .status.conditions. For
example,\n\n\n\ttype FooStatus struct{\n\t // Represents the
observations of a foo's current state.\n\t // Known .status.conditions.type
are: \"Available\", \"Progressing\", and \"Degraded\"\n\t //
+patchMergeKey=type\n\t // +patchStrategy=merge\n\t // +listType=map\n\t
\ // +listMapKey=type\n\t Conditions []metav1.Condition `json:\"conditions,omitempty\"
patchStrategy:\"merge\" patchMergeKey:\"type\" protobuf:\"bytes,1,rep,name=conditions\"`\n\n\n\t
\ // other fields\n\t}"
properties:
lastTransitionTime:
description: lastTransitionTime is the last time the condition
transitioned from one status to another. This should be when
the underlying condition changed. If that is not known, then
using the time when the API field changed is acceptable.
description: |-
lastTransitionTime is the last time the condition transitioned from one status to another.
This should be when the underlying condition changed. If that is not known, then using the time when the API field changed is acceptable.
format: date-time
type: string
message:
description: message is a human readable message indicating
details about the transition. This may be an empty string.
description: |-
message is a human readable message indicating details about the transition.
This may be an empty string.
maxLength: 32768
type: string
observedGeneration:
description: observedGeneration represents the .metadata.generation
that the condition was set based upon. For instance, if .metadata.generation
is currently 12, but the .status.conditions[x].observedGeneration
is 9, the condition is out of date with respect to the current
state of the instance.
description: |-
observedGeneration represents the .metadata.generation that the condition was set based upon.
For instance, if .metadata.generation is currently 12, but the .status.conditions[x].observedGeneration is 9, the condition is out of date
with respect to the current state of the instance.
format: int64
minimum: 0
type: integer
reason:
description: reason contains a programmatic identifier indicating
the reason for the condition's last transition. Producers
of specific condition types may define expected values and
meanings for this field, and whether the values are considered
a guaranteed API. The value should be a CamelCase string.
description: |-
reason contains a programmatic identifier indicating the reason for the condition's last transition.
Producers of specific condition types may define expected values and meanings for this field,
and whether the values are considered a guaranteed API.
The value should be a CamelCase string.
This field may not be empty.
maxLength: 1024
minLength: 1
Expand All @@ -215,11 +217,12 @@ spec:
- Unknown
type: string
type:
description: type of condition in CamelCase or in foo.example.com/CamelCase.
--- Many .condition.type values are consistent across resources
like Available, but because arbitrary conditions can be useful
(see .node.status.conditions), the ability to deconflict is
important. The regex it matches is (dns1123SubdomainFmt/)?(qualifiedNameFmt)
description: |-
type of condition in CamelCase or in foo.example.com/CamelCase.
---
Many .condition.type values are consistent across resources like Available, but because arbitrary conditions can be
useful (see .node.status.conditions), the ability to deconflict is important.
The regex it matches is (dns1123SubdomainFmt/)?(qualifiedNameFmt)
maxLength: 316
pattern: ^([a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*/)?(([A-Za-z0-9][-A-Za-z0-9_.]*)?[A-Za-z0-9])$
type: string
Expand All @@ -237,8 +240,9 @@ spec:
labels:
additionalProperties:
type: string
description: Map of string keys and values corresponding OCI image
config labels. Labels contains arbitrary metadata for the container.
description: |-
Map of string keys and values corresponding OCI image config labels.
Labels contains arbitrary metadata for the container.
type: object
phase:
description: Phase represents a step in a resource processing lifecycle.
Expand Down
Loading

0 comments on commit d9afa13

Please sign in to comment.