merge dominodatalab/testenv into this repository #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not including destruction
we want to be at least v0.25.0 compatible since there are some dep issues with gnostic in k8s v0.23
rather than building a var list during apply and destroy, we can create a "terraform.tfvars" that will be used. additionally, this makes running the terraform steps manually easier when debugging using hclwrite in case we have more complex variables to write for aks/eks. we can remove this is the need does not present itself
and exposes gcp service account and gar repository
apparently these names must be unique from one cluster to the next
i had to remove the community vpc module because it didn't allow me to use dynamic subnet names with secondary ranges
- the ability to pass values into the helmfile apply func - binds gcp SA to the workloadIdentityUser role - adds the ability to query tf output for variable data - adds k8s service account to GKEConfig
* Generated EKS resource creation. * terraform plan is running successfully. * TODO: need to add IAM roles + permissions.
* Reformatted tf files.
* Updated terraform output to include ecr repo url.
* Added kubeconfig as a null resource to update the kubeconfig. * Added nodes to the EKS cluster.
* Changed manage_aws_auth_configmap back to true. * Enabled hostnames though I am unsure if I need that.
- Updated description to specify it's the kubeconfig path and not the actual kubeconfig.
- Updated kubernetes version description.
* Updated k8s version to 1.23 * Updated module format to match other tf modules in our repo.
…env into jade/add-eks-test-env
we want faster tests and do not want to wait for a cluster to scale up when testing
* Added EKS config + validation, kubeconfig output
- adds .terraform.lock.hcl for repeatable init - fixes kubeconfig contents output
- adds ebs-csi add-on so that k8s sc works in k8s version >= 1.23 - adds sg rules for various webhooks running in-cluster; this should really be configurable via variables but that can come later
because we don't care if we're deleting an ECR repo that has test images within it
we want to ensure that callers can still run terraform destroy if/when helmfile destroy fails for some reason. a possible error could be related to an invalid k8s connection
fraenkel
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dominodatalab/testenv is only used here and it's difficult to update. I've merged it in, but kept it separate for now.