Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define rootless/non-rootless image tags separately #246

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

Secretions
Copy link
Collaborator

We currently default to the rootless buildkit image as the only image in the config, and then life-mutate the image tag to what we presume the non-rootless one would be based on a string substitution.

Let's just clearly define the two images and pick the appropriate one.

@Secretions Secretions marked this pull request as ready for review October 30, 2024 21:13
Copy link
Contributor

@ddl-kfrench ddl-kfrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@Secretions Secretions merged commit 2726d89 into main Oct 30, 2024
7 checks passed
@Secretions Secretions deleted the dont-parse-buildkit-tag branch October 30, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants