Exposes the endpointSliceWatchTimeout value #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this was a const before but now it's configurable via the helm chart values -> config also pass a pod to be processed by value to avoid the variable re-declaration with a for loop
sonnysideup
commented
Aug 4, 2022
| if rErr := p.releasePod(ctx, pod); rErr != nil { | ||
| log.Error(err, "Failed to release pod") | ||
| if rErr := p.releasePod(ctx, &pod); rErr != nil { | ||
| log.Error(rErr, "Failed to release pod") |
There was a problem hiding this comment.
This was logging the wrong error.
the value should be an int, not a string
sonnysideup
commented
Aug 4, 2022
| @@ -375,8 +376,7 @@ func (p *workerPool) updateWorkers(ctx context.Context) error { | |||
| if req := p.requests.Dequeue(); req != nil { | |||
| log.Info("Found pending pod request, processing") | |||
|
|
|||
| pod := pod | |||
| if p.processPodRequest(ctx, req, &pod) { | |||
| if p.processPodRequest(ctx, req, pod) { | |||
There was a problem hiding this comment.
Just passing the pod value instead of a pointer to avoid implicit memory aliasing and variable re-declaration.
these will be printed when we fail to resolve an endpoint for buildkit pod
and fixes linting errors
and corrects previous value for poolEndpointWatchTimeout
steved
approved these changes
Aug 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@steved I found this interesting article that describes some of the issues we see in environments where buildkit pods are frequently terminated and re-created.
My conclusion is that (a) my static 90s endpoint watch timeout is too low in certain instances where the buildkit pods churn a lot and (b) this value should be externally configurable so that it can serviced without code changes.
Changes
fetchAndExtractTimeoutvalue to control archive processing time and bumps default fetch retry considerablypoolEndpointWatchTimeoutto allow the configuration of this valuegolangci-lint