Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace AMQP library #83

Merged
merged 6 commits into from
Dec 5, 2022
Merged

Replace AMQP library #83

merged 6 commits into from
Dec 5, 2022

Conversation

sonnysideup
Copy link
Contributor

Using external library now that does not have race conditions causing a deadlock when closing the client during a a reconnect event.

@sonnysideup
Copy link
Contributor Author

sonnysideup commented Dec 5, 2022 •
edited by github-actions bot
Loading

/functional-test


Launched workflow: Functional tests

@sonnysideup
Copy link
Contributor Author

resolves #83

@sonnysideup sonnysideup marked this pull request as ready for review December 5, 2022 19:24
@sonnysideup sonnysideup requested a review from steved as a code owner December 5, 2022 19:24
steved
steved approved these changes Dec 5, 2022
View reviewed changes
test/functional/helpers_test.go Outdated Show resolved Hide resolved
pkg/messaging/amqp/publisher.go Show resolved Hide resolved
sonnysideup and others added 3 commits December 5, 2022 13:07
@sonnysideup
bumps amqp-client version again
30cad1b
@sonnysideup @steved
Update test/functional/helpers_test.go
da1b811 
Co-authored-by: Steven Davidovitz <steved@users.noreply.github.com>
@sonnysideup
removes pkg/messaging/amqp/channelmanager.go
818748d 
forgot to delete this file earlier
@sonnysideup sonnysideup merged commit c7e09d4 into main Dec 5, 2022
@sonnysideup sonnysideup deleted the replace-amqp-lib branch December 5, 2022 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steved steved steved approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sonnysideup @steved