Skip to content

Add composer support #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 13, 2012
Merged

Add composer support #2

merged 1 commit into from
Nov 13, 2012

Conversation

amacneil
Copy link
Contributor

I've added a basic composer.json to this project so that we can list it as a dependency of DOMPDF.

You can now generate a valid autoload.php file by running composer update in the package root. Originally I went through the existing classes and removed all the require_once statements, but I decided it's probably better to leave them there for now, to support anyone still manually including this package.

@PhenX
Copy link
Member

PhenX commented Nov 13, 2012

I must admit I prefer this version ;)

PhenX added a commit that referenced this pull request Nov 13, 2012
@PhenX PhenX merged commit ceb9771 into dompdf:master Nov 13, 2012
@amacneil
Copy link
Contributor Author

Cool. Can you create a tag for this version (just anything like "v0.9" will do), then make sure you push the tag to github (git push --tags) so that the tag appears here: https://github.com/PhenX/php-font-lib/tags

Then submit this to packagist.org so I can list it as a dependency for dompdf :)

@PhenX
Copy link
Member

PhenX commented Nov 14, 2012

Hey, I added it to packagist https://packagist.org/packages/phenx/php-font-lib after making the tag: https://github.com/PhenX/php-font-lib/tags
Is it OK ?

@amacneil
Copy link
Contributor Author

You tagged the version before by recent pull request (so packagist can't see the composer.json file). Can you git pull down the latest changes, then tag the latest commit v0.1.1 or something, then packagist should start working fine :)

@PhenX
Copy link
Member

PhenX commented Nov 15, 2012

No I tagged it after your pull request (39a6d59). But it looks like tagging only makes a zip.
Which URL should I submit in packagist ? I submitted https://github.com/PhenX/php-font-lib, it didn't accept https://github.com/PhenX/php-font-lib/tags

@amacneil
Copy link
Contributor Author

No, you tagged it correctly, but your tag points to 6346e06 (see here: https://github.com/PhenX/php-font-lib/commits/0.1 )

You submitted it to packagist correctly. The only problem is that packagist can only see the "dev-master" branch, since the 0.1 tag doesn't contain a composer.json file.

If you want to give me access to the repo I'm happy to fix up the tag for you. Otherwise you just need to make sure your local git repo is at the correct commit (check with "git log") before you run "git tag". Also don't try to re-tag 0.1, that will make a mess since that tag is already public and re-writing history is bad. Just call the new tag 0.1.1 or something :)

@PhenX
Copy link
Member

PhenX commented Nov 15, 2012

Oh, sh** ! :) I didn't sync my local repo before making the tag ! I'm fixing it.

BuslikDrev added a commit to BuslikDrev/php-font-lib that referenced this pull request Dec 19, 2024
… of type int is deprecated in FontLib\BinaryStream.php on line 123

Unknown: fseek(): Passing null to parameter dompdf#2 ($offset) of type int is deprecated in FontLib\BinaryStream.php on line 123
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants