Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add/modify cmake build files and some MACROs for using netCDF #2

Merged

Conversation

stcui007
Copy link

Add and modify cmake build files, add cmake build option -DNETCDF_ACTIVE, add #ifdef NETCDF_ACTIVE to some C++ code header files and test code.

Additions

cmake/modules/FindNetCDF.cmake

Removals

cmake/FindNetCDF.cmake

Changes

CMakelist.txt
test/CMakelist.txt
include/forcing/DataProviderSelectors.hpp
include/forcing/NetCDFPerFeatureDataProvider.hpp
test/forcing/NetCDFPerFeatureDataProvider_Test.cpp

Testing

test_unit
test_all
test_netcdf_forcing
test_bmi_fortran
test_bmi_cpp
test_bmi_c

Screenshots

Notes

Todos

Checklist

  • [x ] PR has an informative and human-readable title
  • [x ] Changes are limited to a single goal (no scope creep)
  • [x ] Code can be automatically merged (no conflicts)
  • [x ] Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • [x ] Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist (automated report can be put here)

Target Environment support

  • Linux

@donaldwj donaldwj merged commit 53d0985 into donaldwj:unfied_forcing_rebase Apr 19, 2022
donaldwj pushed a commit that referenced this pull request May 5, 2022
* Add capability to use netCDF external library

* Add netCDF parallel component
donaldwj pushed a commit that referenced this pull request May 11, 2022
* Add capability to use netCDF external library

* Add netCDF parallel component
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants