Added support for providers implementing async load and clear methods. #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| var value = storageProvider.getItem(nskey(key)); | ||
| setCache(key, value); // Build cache and publish an "added" events. | ||
| }); | ||
| originalPublish(EventName.ready); // Publish even if options.publish is false. |
zjordan
force-pushed
the
p/zj/add-support-for-providers-implementing-async-load-method
branch
from
76759d7 to
cefbf88
Compare
|
🎱 See comments. |
zjordan
force-pushed
the
p/zj/add-support-for-providers-implementing-async-load-method
branch
from
7e6e4d7 to
c596d42
Compare
| throwIfUninitialized = _.noop; // Allow other methods to work without throwing. | ||
| if (storageProvider.load) { // If provider implements load() - use it. | ||
| asyncLoad(); | ||
| } else { // If prvider does not implement load(), data is loaded using a series of getItem calls. |
zjordan
force-pushed
the
p/zj/add-support-for-providers-implementing-async-load-method
branch
from
c596d42 to
239f9a4
Compare
| that.load = function () { | ||
| if (storageProvider.load) { // If provider implements load() - use it. | ||
| asyncLoad(); | ||
| } else { // If prvider does not implement load(), data is loaded using a series of getItem calls. |
zjordan
force-pushed
the
p/zj/add-support-for-providers-implementing-async-load-method
branch
from
239f9a4 to
5dd56fa
Compare
|
|
||
| function asyncClear() { | ||
| storageProvider.clear(namespace).done(function () { | ||
| var publishReady = initialize(); // Initialize only if needed and return true if initalization was performed. |
|
Looks good to me. I'd like to @donavon to take a look when he can. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.