Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undefined names: 'user' and 'cfg' #4

Closed
cclauss opened this issue Jan 19, 2019 · 1 comment
Closed

Undefined names: 'user' and 'cfg' #4

cclauss opened this issue Jan 19, 2019 · 1 comment

Comments

@cclauss
Copy link
Contributor

cclauss commented Jan 19, 2019

flake8 testing of https://github.com/dongweiming/lyanna on Python 3.7.1

$ flake8 . --count --select=E901,E999,F821,F822,F823 --show-source --statistics

./views/j.py:61:57: F821 undefined name 'user'
    liked_comment_ids = await post.comment_ids_liked_by(user['gid'])
                                                        ^
./views/index.py:91:25: F821 undefined name 'cfg'
        return redirect(cfg.oauth_redirect_path)
                        ^
2     F821 undefined name 'cfg'
2

E901,E999,F821,F822,F823 are the "showstopper" flake8 issues that can halt the runtime with a SyntaxError, NameError, etc. Most other flake8 issues are merely "style violations" -- useful for readability but they do not effect runtime safety.

  • F821: undefined name name
  • F822: undefined name name in __all__
  • F823: local variable name referenced before assignment
  • E901: SyntaxError or IndentationError
  • E999: SyntaxError -- failed to compile a file into an Abstract Syntax Tree
@dongweiming
Copy link
Owner

@cclauss Thank you for your comments, i have fixed it

dongweiming added a commit that referenced this issue Jan 20, 2019
dongweiming added a commit that referenced this issue Jan 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants