Tinyhen project #1
Conversation
There was a problem hiding this comment.
Didn't tested the code but here's a flat review.
Notes:
- if possible, don't rely on any upstream resources for your demos/talks
- you could use proper semver release tags instead of
latest(update imagepullpolicy if you do that) - we can pimp your dashboard during the week if you want
Really nice to have:
- logo & social preview for the project (maybe gophers x hens)
Nice to have:
- pre-commit checks (basic stuff like linters, typos...)
- https://github.com/aquasecurity/trivy-action
doc/app.md
Outdated
| ``` | ||
|
|
||
| ```bash | ||
| curl -v -X POST -H "Content-Type: application/json" http://localhost:10010/measure -d '{"temp": 360, "hum": 480}' |
There was a problem hiding this comment.
a small word why we need to pass value*10 ? (In my opinion, this operation should be done before calling the service or Prometheus)
There was a problem hiding this comment.
This service should be ignorant of the fact that the probe returns you temperature10 and humidity10. Whatever connects the probe to the service should be in charge of making the conversion.
| ```bash | ||
| Creating cluster "tinyhen-test" ... | ||
| ✓ Ensuring node image (kindest/node:v1.24.0) 🖼 | ||
| ✓ Preparing nodes 📦 |
There was a problem hiding this comment.
ERROR: failed to create cluster: command "docker run --name tinyhen-control-plane --hostname tinyhen-control-plane --label io.x-k8s.kind.role=control-plane --privileged --security-opt seccomp=unconfined --security-opt apparmor=unconfined --tmpfs /tmp --tmpfs /run --volume /var --volume /lib/modules:/lib/modules:ro -e KIND_EXPERIMENTAL_CONTAINERD_SNAPSHOTTER --detach --tty --label io.x-k8s.kind.cluster=tinyhen --net kind --restart=on-failure:1 --init=false --publish=0.0.0.0:80:80/TCP --publish=0.0.0.0:443:443/TCP --publish=127.0.0.1:42247:6443/TCP -e KUBECONFIG=/etc/kubernetes/admin.conf kindest/node:v1.24.0@sha256:406fd86d48eaf4c04c7280cd1d2ca1d61e7d0d61ddef0125cb097bc7b82ed6a1" failed with error: exit status 125 Command Output: 473b259f899ff1a5e812dcbfeb777dfba22cda1a8365782d905407e6d6f10dd9 docker: Error response from daemon: driver failed programming external connectivity on endpoint tinyhen-control-plane (cc891218944e96f4a76863a32382831877740bc140bac4c5172e3049d80d594f): Error starting userland proxy: listen tcp4 0.0.0.0:80: bind: address already in use.
(and
github.com/doniacld/tiny-hen dev ✔
▶ lsof -i :80
github.com/doniacld/tiny-hen dev ✔
▶
)
In this PR you will find:
.
├── Dockerfile
├── LICENSE
├── Makefile // To run locally, deploy and make go operations
├── README.md // Need works
├── cmd // Holds the main with a webserver, you can find documentation about it in /doc/app.md
├── deploy // All the needed manifests to deploy a cluster with a monitoring stack and an app
├── doc // 🚧 Still building the documentation, the app.md is the only one finished
├── go.mod
└── go.sum