fix(deps): update dependency moment to v2.30.0 [security] - abandoned

[renovate]

This PR contains the following updates:

Package	Change	Age	Adoption	Passing	Confidence
moment (source)	2.29.4 -> 2.30.0

GitHub Vulnerability Alerts

CVE-2022-24785

Impact

This vulnerability impacts npm (server) users of moment.js, especially if user provided locale string, eg fr is directly used to switch moment locale.

Patches

This problem is patched in 2.29.2, and the patch can be applied to all affected versions (from 1.0.1 up until 2.29.1, inclusive).

Workarounds

Sanitize user-provided locale name before passing it to moment.js.

References

Are there any links users can visit to find out more?

For more information

If you have any questions or comments about this advisory:

• Open an issue in moment repo

CVE-2022-31129

Impact

• using string-to-date parsing in moment (more specifically rfc2822 parsing, which is tried by default) has quadratic (N^2) complexity on specific inputs
• noticeable slowdown is observed with inputs above 10k characters
• users who pass user-provided strings without sanity length checks to moment constructor are vulnerable to (Re)DoS attacks

Patches

The problem is patched in 2.29.4, the patch can be applied to all affected versions with minimal tweaking.

Workarounds

In general, given the proliferation of ReDoS attacks, it makes sense to limit the length of the user input to something sane, like 200 characters or less. I haven't seen legitimate cases of date-time strings longer than that, so all moment users who do pass a user-originating string to constructor are encouraged to apply such a rudimentary filter, that would help with this but also most future ReDoS vulnerabilities.

References

There is an excellent writeup of the issue here: https://github.com/moment/moment/pull/6015#issuecomment-1152961973=

Details

The issue is rooted in the code that removes legacy comments (stuff inside parenthesis) from strings during rfc2822 parsing. moment("(".repeat(500000)) will take a few minutes to process, which is unacceptable.

---

Release Notes

moment/moment (moment)

v2.30.0

Compare Source

• Release Dec 26, 2023

---

Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

---

• If you want to rebase/retry this PR, check this box

---

This PR was generated by Mend Renovate. View the repository job log.

[renovate]

⚠️ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

• any of the package files in this branch needs updating, or
• the branch becomes conflicted, or
• you click the rebase/retry checkbox if found above, or
• you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: package-lock.json

npm error code ERESOLVE
npm error ERESOLVE could not resolve
npm error
npm error While resolving: @angular/flex-layout@9.0.0-beta.31
npm error Found: @angular/cdk@16.1.5
npm error node_modules/@angular/cdk
npm error   @angular/cdk@"16.1.5" from the root project
npm error   peer @angular/cdk@"16.1.5" from @angular/material@16.1.5
npm error   node_modules/@angular/material
npm error     @angular/material@"16.1.5" from the root project
npm error     peer @angular/material@"16.1.5" from @angular/material-moment-adapter@16.1.5
npm error     node_modules/@angular/material-moment-adapter
npm error       @angular/material-moment-adapter@"16.1.5" from the root project
npm error
npm error Could not resolve dependency:
npm error peer @angular/cdk@"^9.0.0-rc.8" from @angular/flex-layout@9.0.0-beta.31
npm error node_modules/@angular/flex-layout
npm error   @angular/flex-layout@"9.0.0-beta.31" from the root project
npm error
npm error Conflicting peer dependency: @angular/cdk@9.2.4
npm error node_modules/@angular/cdk
npm error   peer @angular/cdk@"^9.0.0-rc.8" from @angular/flex-layout@9.0.0-beta.31
npm error   node_modules/@angular/flex-layout
npm error     @angular/flex-layout@"9.0.0-beta.31" from the root project
npm error
npm error Fix the upstream dependency conflict, or retry
npm error this command with --force or --legacy-peer-deps
npm error to accept an incorrect (and potentially broken) dependency resolution.
npm error
npm error
npm error For a full report see:
npm error /tmp/renovate/cache/others/npm/_logs/2024-09-25T14_34_04_976Z-eresolve-report.txt
npm error A complete log of this run can be found in: /tmp/renovate/cache/others/npm/_logs/2024-09-25T14_34_04_976Z-debug-0.log

[renovate]

Autoclosing Skipped

This PR has been flagged for autoclosing. However, it is being skipped due to the branch being already modified. Please close/delete it manually or report a bug if you think this is in error.