Skip to content
This repository has been archived by the owner on Mar 7, 2023. It is now read-only.

etc1s+draco model renders black but textures load #38

Closed
hybridherbst opened this issue Nov 24, 2022 · 4 comments · Fixed by donmccurdy/glTF-Transform-View#47
Closed
Labels
bug Something isn't working
Milestone

Comments

@hybridherbst
Copy link

Describe the bug
This is a weird one: while testing mrdoob/three.js#23321 I noticed that the etc1s+draco version of Coffeemat didn't load properly in gltf.report. Some textures display black, while in the texture view they're available:

To Reproduce
Steps to reproduce the behavior:

  1. Go to gltf.report
  2. Download the files referenced in the issue above
  3. Drop the etc1s+draco file into gltf.report
  4. Note black textures

Screenshots
image

Desktop (please complete the following information):

  • OS: [Windows]
  • Browser [Chrome]
  • Version [107]

Additional context

I remember having this exact model work fine in gltf.report before

@hybridherbst hybridherbst added the bug Something isn't working label Nov 24, 2022
@donmccurdy donmccurdy added this to the v1.5 milestone Nov 25, 2022
@donmccurdy
Copy link
Owner

Thanks! I'll look into this.

I remember having this exact model work fine in gltf.report before

I recently replaced THREE.GLTFLoader with @gltf-transform/view in this viewer, to support lossless roundtrip import/export. That may be the cause of the regression here.

@donmccurdy
Copy link
Owner

donmccurdy commented Nov 30, 2022

Found the fix, but not deployed quite yet. Because three.js doesn't support arbitrary UV assignments, THREE.GLTFLoader backfills TEXCOORD_1 with TEXCOORD_0 if necessary. Had missed that in @gltf-transform/view.

@donmccurdy donmccurdy reopened this Nov 30, 2022
@hybridherbst
Copy link
Author

Ah, that old three-is-not-actually-glTF-compliant issue comes back again... really hope that Node materials are there Soon™️, if you have any pointers to what could be done to accelerate that, happy to align!

@donmccurdy
Copy link
Owner

Fixed on latest gltf.report push!

On THREE.NodeMaterial, I'm not sure — haven't been tracking that work closely enough lately. I suspect its plenty mature enough to be useful, but it remains mostly undocumented. Whether that's because it's still likely to change, or no one has documented it,... I'm not sure. In any case it does seem like some visibility into that roadmap would be reasonable at this point.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants