Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

weld has huge normal tolerance #1028

Closed
rotu opened this issue Jul 16, 2023 · 1 comment · Fixed by #1035
Closed

weld has huge normal tolerance #1028

rotu opened this issue Jul 16, 2023 · 1 comment · Fixed by #1035
Labels
feature New enhancement or request package:functions
Milestone
v3.5

Comments

@rotu
Copy link
Contributor

rotu commented Jul 16, 2023

gltf-transform weld welds vertices with relatively large discrepancies in normal. There is not a command-line option to change this threshold.

image image
@rotu rotu added the bug Something isn't working label Jul 16, 2023
rotu added a commit to rotu/glTF-Transform that referenced this issue Jul 17, 2023
@rotu
Reduce normal tolerance for Weld
53fc29b 
Fix donmccurdy#1028
Chose 0.01 as a default tolerance which corresponds to ±arcsin(0.01)/2 = ±0.286°.
@donmccurdy
Copy link
Owner

Thanks @rotu! I agree 0.5 is probably a larger tolerance than appropriate for the NORMAL attribute. I'll do some tests on other possible values, but if you have ideas or sample models you'd like me to consider, please do share those. :)

@donmccurdy donmccurdy added this to the v3.4 milestone Jul 21, 2023
@rotu rotu mentioned this issue Jul 21, 2023
Merged
@donmccurdy donmccurdy modified the milestones: v3.4, v3.5 Jul 23, 2023
@donmccurdy donmccurdy added feature New enhancement or request and removed bug Something isn't working labels Jul 23, 2023
donmccurdy pushed a commit that referenced this issue Jul 29, 2023
@rotu
Reduce normal tolerance for Weld (#1035)
9525344 
* Reduce normal tolerance for Weld

Fix #1028
Chose 0.01 as a default tolerance which corresponds to ±arcsin(0.01)/2 = ±0.286°.

* Loosen normal tolerance to 0.05
@donmccurdy donmccurdy mentioned this issue Jul 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature New enhancement or request package:functions
Projects
None yet
Milestone
v3.5
Development

Successfully merging a pull request may close this issue.

Reduce normal tolerance for Weld rotu/glTF-Transform
2 participants
@rotu @donmccurdy