Fix errors in morph normal encoding in quantize() and meshopt() #1151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… morph normals and tangents - Morph normals and tangents are not normalized and should be quantized, not filtered - Clamp morph normals and tangents to [-1, 1] - Extend quantize() options to disambiguate vertex attributes from morph attributes - Additional code comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix errors in quantization and meshopt compression of morph normals and tangents.
Morph normals and tangent deltas are not normalized vectors, and should be quantized, not filtered
Clamp morph normals and tangents to [-1, 1]
Extend quantize() options to disambiguate vertex attributes from morph attributes
Fixes Meshopt compression breaks normals and/or tangents on mesh #1142