Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Section on reverse proxies shows a diagram of a forward proxy #1

Closed
joehorsnell opened this issue Mar 8, 2017 · 2 comments
Closed

Section on reverse proxies shows a diagram of a forward proxy #1

joehorsnell opened this issue Mar 8, 2017 · 2 comments
Labels
bug help wanted

Comments

@joehorsnell
Copy link

@donnemartin - your section on reverse proxies shows a diagram (from Wikipedia) of a forward, not a reverse proxy.

Excellent resource by the way (from the sections I've looked at anyway!).
@donnemartin
Copy link
Owner

donnemartin commented Mar 9, 2017 •
edited
Loading

Hi @joehorsnell, nice catch and thanks for the feedback!

Interested in a pull request? It seems like this is the image I should have linked to: https://upload.wikimedia.org/wikipedia/commons/6/67/Reverse_proxy_h2g2bob.svg

donnemartin added a commit that referenced this issue Mar 9, 2017
@donnemartin
Fix #1: Update reverse proxy image
d5f125e
@joehorsnell
Copy link
Author

You're too quick! Yes, I was planning to open a PR the following day (just raised the issue so I didn't forget) but you'd already fixed it by the time I checked back 😃

donnemartin added a commit that referenced this issue Mar 11, 2017
@donnemartin
Merge branch 'master' into develop
ebdb203 
* master:
  Add Dyn DDoS attack link (#13)
  Fix multiple typos (#14)
  Add more disadvantages of REST (#9)
  Fix typo - lobsided -> lopsided (#11)
  Fix typo in Study Guide section (#10)
  Fix #1: Update reverse proxy image (#8)
@anonymousedzika anonymousedzika mentioned this issue Dec 1, 2018
Open
coditamar added a commit to coditamar/system-design-primer that referenced this issue Feb 6, 2023
@coditamar
Fixed two issues and add sanity tests. Issue donnemartin#1: super now…
61b6406 
… calls the right class, donnemartin#2: decoupled the initiatlization of call_center and employee.
@coditamar coditamar mentioned this issue Feb 6, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joehorsnell @donnemartin