Use polyfill for MediaRecorder when the interface is not available #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dontcallmedom
force-pushed
the
safari-recorder-compat
branch
from
7797005
to
634a917
Compare
This update makes a number of changes for the recorder to run under Safari: 1. Playback of the reference audio now uses the Web Audio API to avoid running in situations where Safari expects a user activation 2. For consistency, the Web Audio API is used everywhere, allowing to use classic record / play / pause / stop buttons throughout. 3. To allow early tests of the recording (and ease debugging), the recorded audio can be played back even if it's incomplete (but only complete recordings can be updated) 4. A few hacks/workarounds were added, identified by "Safari compat notes" comments in the code
dontcallmedom
commented
Sep 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restarting from #21 to address #24 with conflicts resolved; needs to add user-activation and load streamlining